Re: [RFC/Patch 1/5] Remove old enum definition of "Translate Spa"

[Yasunori Goto <y-goto@jp.fujitsu.com>]

> On Fri, Aug 4, 2017 at 2:06 AM, Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> >
> > Remove old enum definition of "Translate Spa".
> >
> > Translate SPA becomes standard specification on ACPI 6.2,
> > but current definition is likely temporary.
> > So it is removed.
> >
> > Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
> >
> >
> > ---
> >  drivers/acpi/nfit/core.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > index 19182d0..5334755 100644
> > --- a/drivers/acpi/nfit/core.c
> > +++ b/drivers/acpi/nfit/core.c
> > @@ -1626,7 +1626,6 @@ static int acpi_nfit_register_dimms(struct acpi_nfit_desc *acpi_desc)
> >   * these commands.
> >   */
> >  enum nfit_aux_cmds {
> > -        NFIT_CMD_TRANSLATE_SPA = 5,
> >          NFIT_CMD_ARS_INJECT_SET = 7,
> >          NFIT_CMD_ARS_INJECT_CLEAR = 8,
> >          NFIT_CMD_ARS_INJECT_GET = 9,
> > @@ -1655,7 +1654,6 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc)
> >                 (1 << ND_CMD_ARS_START) |
> >                 (1 << ND_CMD_ARS_STATUS) |
> >                 (1 << ND_CMD_CLEAR_ERROR) |
> > -               (1 << NFIT_CMD_TRANSLATE_SPA) |
> >                 (1 << NFIT_CMD_ARS_INJECT_SET) |
> >                 (1 << NFIT_CMD_ARS_INJECT_CLEAR) |
> >                 (1 << NFIT_CMD_ARS_INJECT_GET);
> 
> Hmm, those definitions are brand new as of the 4.13 kernel, see commit
> 7db5bb33add5 "libnvdimm, acpi, nfit: Add bus level dsm mask for pass
> thru". What's going on here is that we stopped defining new ND_CMD
> numbers for each new DSM that is added to the specification. Instead,
> we use the ND_CMD_CALL mechanism to wrap these new command payloads
> and pass them through to the BIOS. So, these definitions are needed to
> allow that passthrough mechanism to work.

Ah, Ok.
I'll check it.


Thanks,



_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm