From: Vishal Verma <vishal.l.verma@intel.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: vishal.verma@intel.com, linux-nvdimm@lists.01.org
Subject: Re: [ndctl patch] btt_check_bitmap: initialize rc
Date: Tue, 31 Oct 2017 13:32:25 -0600 [thread overview]
Message-ID: <20171031193225.GC5253@omniknight.lm.intel.com> (raw)
In-Reply-To: <x49k1zperpp.fsf@segfault.boston.devel.redhat.com>
On 10/20, Jeff Moyer wrote:
> It may be possible that rc is never set before returning from
> the function. nfree would have to be zero, and the bitmap
> would have to be full. Fix it.
>
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Ah so it shouldn't ever happen in practice, but I can see how a static
checker may complain about it. The patch looks good to me.
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>
> diff --git a/ndctl/check.c b/ndctl/check.c
> index 915bb9d..dafd6a8 100644
> --- a/ndctl/check.c
> +++ b/ndctl/check.c
> @@ -508,7 +508,7 @@ static int btt_check_bitmap(struct arena_info *a)
> {
> unsigned long *bm;
> u32 i, btt_mapping;
> - int rc;
> + int rc = BTT_BITMAP_ERROR;
>
> bm = bitmap_alloc(a->internal_nlba);
> if (bm == NULL)
> @@ -521,7 +521,6 @@ static int btt_check_bitmap(struct arena_info *a)
> info(a->bttc,
> "arena %d: internal block %#x is referenced by two map entries\n",
> a->num, btt_mapping);
> - rc = BTT_BITMAP_ERROR;
> goto out;
> }
> bitmap_set(bm, btt_mapping, 1);
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2017-10-31 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 15:58 [ndctl patch] btt_check_bitmap: initialize rc Jeff Moyer
2017-10-31 19:32 ` Vishal Verma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031193225.GC5253@omniknight.lm.intel.com \
--to=vishal.l.verma@intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox