From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 47D3F2034A76F for ; Wed, 6 Dec 2017 14:40:11 -0800 (PST) Date: Wed, 6 Dec 2017 23:44:41 +0100 From: Christoph Hellwig Subject: Re: [PATCH 2/2] mm: fix dev_pagemap reference counting around get_dev_pagemap Message-ID: <20171206224441.GA14274@lst.de> References: <20171205003443.22111-1-hch@lst.de> <20171205003443.22111-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Linux MM , Christoph Hellwig , "linux-nvdimm@lists.01.org" List-ID: On Tue, Dec 05, 2017 at 06:43:36PM -0800, Dan Williams wrote: > I don't think we need this change, but perhaps the reasoning should be > added to the code as a comment... details below. Hmm, looks like we are ok at least. But even if it's not a correctness issue there is no good point in decrementing and incrementing the reference count every time. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm