Re: [xfsprogs PATCH v2 3/3] xfs_io: add a new 'log_writes' command

Ross Zwisler
2017-12-06T04:33:42Z

On Wed, Dec 06, 2017 at 11:29:46AM +1100, Dave Chinner wrote:
> On Tue, Dec 05, 2017 at 04:56:51PM -0700, Ross Zwisler wrote:
> > Add a new 'log_writes' command to xfs_io so that we can add dm-log-writes
> > log marks. It's helpful to allow users of xfs_io to adds these marks from
> > within xfs_io instead of waiting until after xfs_io exits because then they
> > are able to replay the dm-log-writes log up to immediately after another
> > xfs_io operation such as mwrite. This isolates the log replay from other
> > operations that happen as part of xfs_io exiting (file handles being
> > closed, mmaps being torn down, etc.). This also allows users to insert
> > multiple marks between different xfs_io commands.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > Suggested-by: Dave Chinner <david@fromorbit.com>
>
> having just looked at the xfs_io mess, this new command needs to set
> "exitcode = 1" on failure. I haven't looked at anything else in the
> patch.

Ah, yea, I did think it was odd that when hitting errors in xfs_io it always
still returned 0. I'll fix up for the next version. Is someone else working
on making the rest of the error cases in xfs_io return 1 as well, or should I
throw that at the front of the series?