From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4489E220F33C2 for ; Thu, 15 Feb 2018 13:41:16 -0800 (PST) Date: Thu, 15 Feb 2018 13:47:08 -0800 From: Christoph Hellwig Subject: Re: [PATCH v5 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX Message-ID: <20180215214708.GA10446@infradead.org> References: <151873070632.53899.3320294279108510082.stgit@djiang5-desk3.ch.intel.com> <151873085471.53899.4916392112937742603.stgit@djiang5-desk3.ch.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <151873085471.53899.4916392112937742603.stgit@djiang5-desk3.ch.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dave Jiang Cc: linux-nvdimm@lists.01.org, darrick.wong@oracle.com, david@fromorbit.com, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org List-ID: > + if ((XFS_IS_REALTIME_INODE(ip)) && No need for the inner braces. Except for that the whole series looks fine to me. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm