From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [PATCH v6 0/4] ndctl: convert actions to use util_filter_walk
Date: Fri, 11 May 2018 19:34:50 -0600 [thread overview]
Message-ID: <20180512013450.GA4189@linux.intel.com> (raw)
In-Reply-To: <152607009656.4523.5355287262776399070.stgit@djiang5-desk3.ch.intel.com>
On Fri, May 11, 2018 at 01:24:36PM -0700, Dave Jiang wrote:
> util_filter_walk() does the looping through bus/dimm/region/namespace
> that a lot of the operations in ndctl uses. Converting them to common
> code and reduce maintenance on individual versions of the same code.
> In this series we are convering namespace, region, and dimm actions.
<>
> ndctl/dimm.c | 78 +++++++++++++---------
> ndctl/namespace.c | 189 +++++++++++++++++++++++++++++------------------------
> ndctl/region.c | 54 +++++++++------
> util/filter.c | 11 +++
> util/filter.h | 25 +++++++
> 5 files changed, 212 insertions(+), 145 deletions(-)
Just from the cover letter I'm sort of confused - the paragraph above says we
are converging on common code and removing individual versions of the same
code...but the patch series grows this code by 70 lines? I would have
expected this to be a net code reduction?
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-05-12 1:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 20:24 [PATCH v6 0/4] ndctl: convert actions to use util_filter_walk Dave Jiang
2018-05-11 20:24 ` [PATCH v6 1/4] ndctl: convert namespace actions to use util_filter_params Dave Jiang
2018-05-12 1:46 ` Ross Zwisler
2018-05-11 20:24 ` [PATCH v6 2/4] ndctl: convert namespace actions to use util_filter_walk() Dave Jiang
2018-05-11 20:24 ` [PATCH v6 3/4] ndctl: convert region " Dave Jiang
2018-05-11 20:24 ` [PATCH v6 4/4] ndctl: convert dimm " Dave Jiang
2018-05-12 1:34 ` Ross Zwisler [this message]
2018-05-12 1:43 ` [PATCH v6 0/4] ndctl: convert actions to use util_filter_walk Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180512013450.GA4189@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).