From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5FEBE210E0FA7 for ; Fri, 11 May 2018 18:34:51 -0700 (PDT) Date: Fri, 11 May 2018 19:34:50 -0600 From: Ross Zwisler Subject: Re: [PATCH v6 0/4] ndctl: convert actions to use util_filter_walk Message-ID: <20180512013450.GA4189@linux.intel.com> References: <152607009656.4523.5355287262776399070.stgit@djiang5-desk3.ch.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <152607009656.4523.5355287262776399070.stgit@djiang5-desk3.ch.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dave Jiang Cc: linux-nvdimm@lists.01.org List-ID: On Fri, May 11, 2018 at 01:24:36PM -0700, Dave Jiang wrote: > util_filter_walk() does the looping through bus/dimm/region/namespace > that a lot of the operations in ndctl uses. Converting them to common > code and reduce maintenance on individual versions of the same code. > In this series we are convering namespace, region, and dimm actions. <> > ndctl/dimm.c | 78 +++++++++++++--------- > ndctl/namespace.c | 189 +++++++++++++++++++++++++++++------------------------ > ndctl/region.c | 54 +++++++++------ > util/filter.c | 11 +++ > util/filter.h | 25 +++++++ > 5 files changed, 212 insertions(+), 145 deletions(-) Just from the cover letter I'm sort of confused - the paragraph above says we are converging on common code and removing individual versions of the same code...but the patch series grows this code by 70 lines? I would have expected this to be a net code reduction? _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm