From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [PATCH] tools/testing/nvdimm: advertise a write cache for nfit_test
Date: Mon, 18 Jun 2018 19:56:21 -0600 [thread overview]
Message-ID: <20180619015621.GA28069@linux.intel.com> (raw)
In-Reply-To: <20180618231702.16503-1-vishal.l.verma@intel.com>
On Mon, Jun 18, 2018 at 05:17:02PM -0600, Vishal Verma wrote:
> Commit 546eb0317cfa "libnvdimm, pmem: Do not flush power-fail protected CPU caches"
> fixed the write_cache detection to correctly show the lack of a write
> cache based on the platform capabilities described in the ACPI NFIT. The
> nfit_test unit tests expected a write cache to be present, so change the
> nfit test namespaces to only advertise a persistence domain limited to
> the memory controller. This allows the kernel to show a write_cache
> attribute, and the test behaviour remains unchanged.
>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Sure, this makes sense to me. Thanks for the fix.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-06-19 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 23:17 [PATCH] tools/testing/nvdimm: advertise a write cache for nfit_test Vishal Verma
2018-06-19 1:56 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619015621.GA28069@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox