Re: [ndctl PATCH 0/5] ndctl: misc static analysis fixes

Dave Jiang
2018-08-10T22:58:08Z

On 08/10/2018 03:56 PM, Vishal Verma wrote:
> Fix up various static analysis reports from recent (and not-so-recent)
> patches.
>
> Vishal Verma (5):
> ndctl, inject: fix a resource leak in ndctl_namespace_get_clear_unit
> ndctl: fix a resource leak in submit_get_firmware_info
> libndctl: fix a resource leak in ndctl_dimm_get_{{event_}flags,
> health}
> ndctl, test: fix a potential null pointer dereference in 'ndctl test'
> ndctl, test: fix a resource leak in check_smart_threshold
>
> ndctl/dimm.c | 17 ++++++++++-------
> ndctl/lib/inject.c | 12 +++++++-----
> ndctl/lib/libndctl.c | 3 +++
> ndctl/test.c | 2 ++
> test/libndctl.c | 1 +
> 5 files changed, 23 insertions(+), 12 deletions(-)
>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>