Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

Christoph Hellwig
2018-09-11T07:06:34Z

On Mon, Sep 10, 2018 at 12:11:01PM -0600, Logan Gunthorpe wrote:
> > I just saw you added that "helper" in your tree. Please don't, it is
> > a negative value add as it doesn't help anything with the checking.
>
> Alright, so what's the consensus then? Just have a check in
> nvmet_bdev_execute_rw() to add REQ_NOMERGE when appropriate?

Yes.