From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2A089211E2C0A for ; Thu, 21 Mar 2019 06:45:58 -0700 (PDT) Date: Thu, 21 Mar 2019 15:45:49 +0200 From: Jarkko Sakkinen Subject: Re: [PATCH 0/6] security/keys/encrypted: Break module dependency chain Message-ID: <20190321134549.GB4603@linux.intel.com> References: <155297557534.2276575.16264199708584900090.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: David Howells , linux-nvdimm , James Bottomley , ecryptfs@vger.kernel.org, Roberto Sassu , Linux Kernel Mailing List , Mimi Zohar , Tyler Hicks , keyrings@vger.kernel.org, linux-integrity@vger.kernel.org List-ID: On Tue, Mar 19, 2019 at 02:01:44PM -0700, Dan Williams wrote: > On Mon, Mar 18, 2019 at 11:18 PM Dan Williams wrote: > > > > With v5.1-rc1 all the nvdimm sub-system regression tests started failing > > because the libnvdimm module failed to load in the qemu-kvm test > > environment. Critically that environment does not have a TPM. Commit > > 240730437deb "KEYS: trusted: explicitly use tpm_chip structure..." > > started to require a TPM to be present for the trusted.ko module to load > > where there was no requirement for that before. > > > > Rather than undo the "fail if no hardware" behavior James points out > > that the module dependencies can be broken by looking up the key-type by > > name. Remove the dependencies on the "key_type_trusted" and > > "key_type_encrypted" symbol exports, and clean up other boilerplate that > > supported those exports in different configurations. > > Any feedback? Was hoping to get at least patch1 in the queue for > v5.1-rc2 since this effectively disables the nvdimm driver on typical > configurations. Jarkko, would you be willing to merge it since the > regression came through your tree? Yes, of course. The feedback has been extremely passive because I've been sick leave for the early week :-) Before I'm merging this I'm just thinking that would it be better idea to merge a patch for trusted.c that reverts the old behavior with cc to stable and fixes tags as I said in my earlier response. It would less intrusive for stable kernels. Lets quickly sort out the best strategy before merging. /Jarkko _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm