From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Liu, Yongxin" <Yongxin.Liu@windriver.com>
Cc: "linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"Gortmaker, Paul <Paul.Gortmaker@windriver.com>,
tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH RT] nvdimm: make lane acquirement RT aware
Date: Thu, 28 Mar 2019 18:38:59 +0100 [thread overview]
Message-ID: <20190328173858.hpbtoep42ucomav2@linutronix.de> (raw)
In-Reply-To: <597B109EC20B76429F71A8A97770610D12A649C1@ALA-MBD.corp.ad.wrs.com>
On 2019-03-18 11:48:28 [+0000], Liu, Yongxin wrote:
>
> >
> > Bummer. That would dead lock indeed.
> > Is it easily possible to recognize the recursive case?
>
> Not easily. I don't have test case for recursive call.
> For now, just code analysis.
So I've been playing with qemu's nvdimm device. So I *think* the
recursive case is here not possible because qemu only supports pmem
while it would require the blk mode to trigger it. It is just a wild
guess…
On top of qemu's nvdimm device I can create a block device via
ndctl create-namespace namespace0.0 --mode=sector
and then I trigger the code path in question.
I would *really* prefer to understand the recursive case and avoid it.
That way the recursive case is explicitly known and uses another path.
The lock can then be always acquired which gives you always lockdep
coverage (which is now missing unless you have more LANEs than CPUs).
The local_lock thingy is completely unneeded: a simple get_cpu_light()
would do the job.
> Yongxin
Sebastian
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-03-28 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 9:57 [PATCH RT] nvdimm: make lane acquirement RT aware Yongxin Liu
2019-03-06 16:35 ` Dan Williams
2019-03-07 14:33 ` Sebastian Andrzej Siewior
2019-03-08 0:07 ` Liu, Yongxin
2019-03-08 9:41 ` Sebastian Andrzej Siewior
2019-03-11 0:44 ` Liu, Yongxin
2019-03-15 16:42 ` Sebastian Andrzej Siewior
2019-03-18 1:41 ` Liu, Yongxin
2019-03-18 11:40 ` Sebastian Andrzej Siewior
2019-03-18 11:48 ` Liu, Yongxin
2019-03-28 17:38 ` Sebastian Andrzej Siewior [this message]
2019-03-08 6:31 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328173858.hpbtoep42ucomav2@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Yongxin.Liu@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox