From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 90847211F99AA for ; Thu, 4 Apr 2019 14:05:06 -0700 (PDT) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x34L48aD027937 for ; Thu, 4 Apr 2019 17:05:05 -0400 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rnr6ukc5s-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 04 Apr 2019 17:05:04 -0400 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 4 Apr 2019 22:05:02 +0100 Date: Thu, 4 Apr 2019 14:04:56 -0700 From: "Paul E. McKenney" Subject: Re: [PATCH RFC tip/core/rcu 1/4] dax/super: Dynamically allocate dax_srcu References: <20190402142816.GA13084@linux.ibm.com> <20190402142933.14547-1-paulmck@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Message-Id: <20190404210456.GN14111@linux.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: paulmck@linux.ibm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: David Howells , Thomas Gleixner , linux-nvdimm , Peter Zijlstra , fweisbec@gmail.com, jiangshanlai@gmail.com, Linux Kernel Mailing List , Steven Rostedt , Josh Triplett , rcu@vger.kernel.org, Eric Dumazet , Mathieu Desnoyers , Oleg Nesterov , dipankar@in.ibm.com, joel@joelfernandes.org, Andrew Morton , Ingo Molnar , Tejun Heo List-ID: On Wed, Apr 03, 2019 at 11:31:01AM -0700, Dan Williams wrote: > On Tue, Apr 2, 2019 at 7:29 AM Paul E. McKenney wrote: > > > > Having DEFINE_SRCU() or DEFINE_STATIC_SRCU() in a loadable module > > requires that the size of the reserved region be increased, which is > > not something we really want to be doing. This commit therefore removes > > the DEFINE_STATIC_SRCU() from drivers/dax/super.c in favor of defining > > dax_srcu as a simple srcu_struct, initializing it in dax_core_init(), > > and cleaning it up in dax_core_exit(). > > > > Reported-by: kbuild test robot > > Signed-off-by: Paul E. McKenney > > Looks good to me. > > Reviewed-by: Dan Williams Applied, thank you! Thanx, Paul _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm