From: Wei Yang <richardw.yang@linux.intel.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: zwisler@kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH] libnvdimm, namespace: check nsblk->uuid immediately after its allocation
Date: Tue, 4 Jun 2019 11:10:41 +0800 [thread overview]
Message-ID: <20190604031041.GA27794@richard> (raw)
In-Reply-To: <20190116065144.3499-1-richardw.yang@linux.intel.com>
Hi, Dan
Do you have some time on this?
On Wed, Jan 16, 2019 at 02:51:44PM +0800, Wei Yang wrote:
>When creating nd_namespace_blk, its uuid is copied from nd_label->uuid.
>In case the memory allocation fails, it goes to the error branch.
>
>This check is better to be done immediately after memory allocation,
>while current implementation does this after assigning claim_class.
>
>This patch moves the check immediately after uuid allocation.
>
>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>---
> drivers/nvdimm/namespace_devs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
>index 681af3a8fd62..9471b9ca04f5 100644
>--- a/drivers/nvdimm/namespace_devs.c
>+++ b/drivers/nvdimm/namespace_devs.c
>@@ -2240,11 +2240,11 @@ static struct device *create_namespace_blk(struct nd_region *nd_region,
> nsblk->lbasize = __le64_to_cpu(nd_label->lbasize);
> nsblk->uuid = kmemdup(nd_label->uuid, NSLABEL_UUID_LEN,
> GFP_KERNEL);
>+ if (!nsblk->uuid)
>+ goto blk_err;
> if (namespace_label_has(ndd, abstraction_guid))
> nsblk->common.claim_class
> = to_nvdimm_cclass(&nd_label->abstraction_guid);
>- if (!nsblk->uuid)
>- goto blk_err;
> memcpy(name, nd_label->name, NSLABEL_NAME_LEN);
> if (name[0])
> nsblk->alt_name = kmemdup(name, NSLABEL_NAME_LEN,
>--
>2.19.1
--
Wei Yang
Help you, Help me
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-06-04 3:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 6:51 [PATCH] libnvdimm, namespace: check nsblk->uuid immediately after its allocation Wei Yang
2019-06-04 3:10 ` Wei Yang [this message]
2019-06-25 22:06 ` Dan Williams
2019-06-26 0:26 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604031041.GA27794@richard \
--to=richardw.yang@linux.intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox