From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 6 Jun 2019 09:10:46 -0700 From: Ira Weiny Subject: Re: [PATCH RFC 03/10] mm/gup: Pass flags down to __gup_device_huge* calls Message-ID: <20190606161045.GA11331@iweiny-DESK2.sc.intel.com> References: <20190606014544.8339-1-ira.weiny@intel.com> <20190606014544.8339-4-ira.weiny@intel.com> <20190606061819.GA20520@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190606061819.GA20520@infradead.org> Sender: owner-linux-mm@kvack.org To: Christoph Hellwig Cc: Dan Williams , Jan Kara , Theodore Ts'o , Jeff Layton , Dave Chinner , Matthew Wilcox , linux-xfs@vger.kernel.org, Andrew Morton , John Hubbard , =?iso-8859-1?B?Suly9G1l?= Glisse , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org List-ID: On Wed, Jun 05, 2019 at 11:18:19PM -0700, Christoph Hellwig wrote: > On Wed, Jun 05, 2019 at 06:45:36PM -0700, ira.weiny@intel.com wrote: > > From: Ira Weiny > > > > In order to support checking for a layout lease on a FS DAX inode these > > calls need to know if FOLL_LONGTERM was specified. > > > > Prepare for this with this patch. > > The GUP fast argument passing is a mess. That is why I've come up > with this as part of the (not ready) get_user_pages_fast_bvec > implementation: > > http://git.infradead.org/users/hch/misc.git/commitdiff/c3d019802dbde5a4cc4160e7ec8ccba479b19f97 Agreed that looks better. And I'm sure I will have to re-roll this to deal with conflicts with this set. But for now I needed this for the follow ons and having a nice separate little patch like this means I can just drop it after I get your clean up! :-D Ira