From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 14 Jun 2019 08:39:26 +0200 From: Christoph Hellwig Subject: Re: [PATCH 17/22] mm: remove hmm_devmem_add Message-ID: <20190614063926.GL7246@lst.de> References: <20190613094326.24093-1-hch@lst.de> <20190613094326.24093-18-hch@lst.de> <20190613194239.GX22062@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190613194239.GX22062@mellanox.com> Sender: owner-linux-mm@kvack.org To: Jason Gunthorpe Cc: Christoph Hellwig , Dan Williams , =?iso-8859-1?B?Suly9G1l?= Glisse , Ben Skeggs , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-nvdimm@lists.01.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: On Thu, Jun 13, 2019 at 07:42:43PM +0000, Jason Gunthorpe wrote: > On Thu, Jun 13, 2019 at 11:43:20AM +0200, Christoph Hellwig wrote: > > There isn't really much value add in the hmm_devmem_add wrapper. Just > > factor out a little helper to find the resource, and otherwise let the > > driver implement the dev_pagemap_ops directly. > > Was this commit message written when other patches were squashed in > here? I think the helper this mentions was from an earlier patch Yes, it was written before a lot of bits were split out. I've updated it for the next version.