Re: [PATCH v5 06/18] kbuild: enable building KUnit

Brendan Higgins
2019-06-25T22:41:29Z

On Tue, Jun 25, 2019 at 3:13 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> On Mon, Jun 17, 2019 at 01:26:01AM -0700, Brendan Higgins wrote:
> > diff --git a/Kconfig b/Kconfig
> > index 48a80beab6853..10428501edb78 100644
> > --- a/Kconfig
> > +++ b/Kconfig
> > @@ -30,3 +30,5 @@ source "crypto/Kconfig"
> > source "lib/Kconfig"
> >
> > source "lib/Kconfig.debug"
> > +
> > +source "kunit/Kconfig"
>
> This patch would break compilation as kunit/Kconfig is not introduced. This
> would would also break bisectability on this commit. This change should
> either be folded in to the next patch, or just be a separate patch after
> the next one.

Maybe my brain isn't working right now, but I am pretty darn sure that
I introduce kunit/Kconfig in the very first patch of this series.
Quoting from the change summary from the first commit:

> include/kunit/test.h | 161 +++++++++++++++++++++++++++++++++
> kunit/Kconfig | 17 ++++
> kunit/Makefile | 1 +
> kunit/test.c | 210 +++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 389 insertions(+)
> create mode 100644 include/kunit/test.h
> create mode 100644 kunit/Kconfig

I am not crazy, right?

> create mode 100644 kunit/Makefile
> create mode 100644 kunit/test.c