Re: [PATCH 08/25] memremap: move dev_pagemap callbacks into a separate structure

Dan Williams
2019-06-17T17:52:03Z

On Mon, Jun 17, 2019 at 5:27 AM Christoph Hellwig <hch@lst.de> wrote:
>
> The dev_pagemap is a growing too many callbacks. Move them into a
> separate ops structure so that they are not duplicated for multiple
> instances, and an attacker can't easily overwrite them.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
> ---
> drivers/dax/device.c | 11 ++++++----
> drivers/dax/pmem/core.c | 2 +-
> drivers/nvdimm/pmem.c | 19 +++++++++-------
> drivers/pci/p2pdma.c | 9 +++++---
> include/linux/memremap.h | 36 +++++++++++++++++--------------
> kernel/memremap.c | 18 ++++++++--------
> mm/hmm.c | 10 ++++++---
> tools/testing/nvdimm/test/iomap.c | 9 ++++----
> 8 files changed, 65 insertions(+), 49 deletions(-)
>
[..]
> diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c
> index 219dd0a1cb08..a667d974155e 100644
> --- a/tools/testing/nvdimm/test/iomap.c
> +++ b/tools/testing/nvdimm/test/iomap.c
> @@ -106,11 +106,10 @@ EXPORT_SYMBOL(__wrap_devm_memremap);
>
> static void nfit_test_kill(void *_pgmap)
> {
> - struct dev_pagemap *pgmap = _pgmap;

Whoops, needed to keep this line to avoid:

tools/testing/nvdimm/test/iomap.c:109:11: error: ‘pgmap’ undeclared
(first use in this function); did you mean ‘_pgmap’?