From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7E99F21295CBF for ; Mon, 17 Jun 2019 13:10:28 -0700 (PDT) Date: Mon, 17 Jun 2019 22:09:57 +0200 From: Christoph Hellwig Subject: Re: [PATCH 08/25] memremap: move dev_pagemap callbacks into a separate structure Message-ID: <20190617200957.GA20645@lst.de> References: <20190617122733.22432-1-hch@lst.de> <20190617122733.22432-9-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: linux-nvdimm@lists.01.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Jason Gunthorpe , Ben Skeggs , linux-pci@vger.kernel.org, Christoph Hellwig List-ID: On Mon, Jun 17, 2019 at 02:08:14PM -0600, Logan Gunthorpe wrote: > I just noticed this is missing a line to set pgmap->ops to > pci_p2pdma_pagemap_ops. I must have gotten confused by the other users > in my original review. Though I'm not sure how this compiles as the new > struct is static and unused. However, it is rendered moot in Patch 16 > when this is all removed. It probably was there in the original and got lost in the merge conflicts from the rebase. I should have dropped all the reviewed-bys for patches with non-trivial merge resolution, sorry. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm