From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5387E2129F11B for ; Tue, 25 Jun 2019 16:03:49 -0700 (PDT) Received: by mail-pl1-f194.google.com with SMTP id g4so253659plb.5 for ; Tue, 25 Jun 2019 16:03:49 -0700 (PDT) Date: Tue, 25 Jun 2019 23:03:46 +0000 From: Luis Chamberlain Subject: Re: [PATCH v5 06/18] kbuild: enable building KUnit Message-ID: <20190625230346.GR19023@42.do-not-panic.com> References: <20190617082613.109131-1-brendanhiggins@google.com> <20190617082613.109131-7-brendanhiggins@google.com> <20190625221318.GO19023@42.do-not-panic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: Petr Mladek , "open list:DOCUMENTATION" , Peter Zijlstra , Amir Goldstein , dri-devel , Sasha Levin , Masahiro Yamada , Michael Ellerman , "open list:KERNEL SELFTEST FRAMEWORK" , shuah , Rob Herring , linux-nvdimm , Frank Rowand , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild , "Bird, Timothy , linux-um@lists.infradead.org, Steven Rostedt" , Julia Lawall , Josh Poimboeuf , kunit-dev@googlegroups.com, Theodore Ts'o , Richard Weinberger , Stephen Boyd , Greg KH , Randy Dunlap , Linux Kernel Mailing List , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org, Kevin Hilman List-ID: On Tue, Jun 25, 2019 at 03:41:29PM -0700, Brendan Higgins wrote: > On Tue, Jun 25, 2019 at 3:13 PM Luis Chamberlain wrote: > > > > On Mon, Jun 17, 2019 at 01:26:01AM -0700, Brendan Higgins wrote: > > > diff --git a/Kconfig b/Kconfig > > > index 48a80beab6853..10428501edb78 100644 > > > --- a/Kconfig > > > +++ b/Kconfig > > > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > > > source "lib/Kconfig" > > > > > > source "lib/Kconfig.debug" > > > + > > > +source "kunit/Kconfig" > > > > This patch would break compilation as kunit/Kconfig is not introduced. This > > would would also break bisectability on this commit. This change should > > either be folded in to the next patch, or just be a separate patch after > > the next one. > > Maybe my brain isn't working right now, but I am pretty darn sure that > I introduce kunit/Kconfig in the very first patch of this series. > Quoting from the change summary from the first commit: Indeed, my mistake, thanks! Luis _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm