Re: [PATCH 03/25] mm: remove hmm_devmem_add_resource

Christoph Hellwig
2019-06-27T16:54:28Z

On Thu, Jun 27, 2019 at 04:18:22PM +0000, Jason Gunthorpe wrote:
> On Wed, Jun 26, 2019 at 02:27:02PM +0200, Christoph Hellwig wrote:
> > This function has never been used since it was first added to the kernel
> > more than a year and a half ago, and if we ever grow a consumer of the
> > MEMORY_DEVICE_PUBLIC infrastructure it can easily use devm_memremap_pages
> > directly.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
> > Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> > Acked-by: Michal Hocko <mhocko@suse.com>
> > ---
> > include/linux/hmm.h | 3 ---
> > mm/hmm.c | 50 ---------------------------------------------
> > 2 files changed, 53 deletions(-)
>
> This should be squashed to the new earlier patch?

We could do that. Do you just want to do that when you apply it?