From: Pankaj Gupta <pagupta@redhat.com>
To: virtualization@lists.linux-foundation.org, dan.j.williams@intel.com
Cc: mst@redhat.com, cohuck@redhat.com, linux-kernel@vger.kernel.org,
yuval.shaia@oracle.com, lcapitulino@redhat.com,
linux-nvdimm@lists.01.org
Subject: [PATCH] virtio_pmem: fix sparse warning
Date: Wed, 10 Jul 2019 19:57:00 +0530 [thread overview]
Message-ID: <20190710142700.10215-1-pagupta@redhat.com> (raw)
This patch fixes below sparse warning related to __virtio
type in virtio pmem driver. This is reported by Intel test
bot on linux-next tree.
nd_virtio.c:56:28: warning: incorrect type in assignment (different base types)
nd_virtio.c:56:28: expected unsigned int [unsigned] [usertype] type
nd_virtio.c:56:28: got restricted __virtio32
nd_virtio.c:93:59: warning: incorrect type in argument 2 (different base types)
nd_virtio.c:93:59: expected restricted __virtio32 [usertype] val
nd_virtio.c:93:59: got unsigned int [unsigned] [usertype] ret
Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Reported-by: kbuild test robot <lkp@intel.com>
---
This fixes a warning, so submitting it as a separate
patch on top of virtio pmem series.
include/uapi/linux/virtio_pmem.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/virtio_pmem.h b/include/uapi/linux/virtio_pmem.h
index efcd72f2d20d..f89129bf1f84 100644
--- a/include/uapi/linux/virtio_pmem.h
+++ b/include/uapi/linux/virtio_pmem.h
@@ -23,12 +23,12 @@ struct virtio_pmem_config {
struct virtio_pmem_resp {
/* Host return status corresponding to flush request */
- __u32 ret;
+ __virtio32 ret;
};
struct virtio_pmem_req {
/* command type */
- __u32 type;
+ __virtio32 type;
};
#endif
--
2.20.1
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next reply other threads:[~2019-07-10 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 14:27 Pankaj Gupta [this message]
2019-07-11 17:45 ` [PATCH] virtio_pmem: fix sparse warning Michael S. Tsirkin
2019-07-11 18:37 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710142700.10215-1-pagupta@redhat.com \
--to=pagupta@redhat.com \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox