From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F9262132BD0F for ; Tue, 13 Aug 2019 10:09:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20190812182421.141150-1-brendanhiggins@google.com> <20190812182421.141150-13-brendanhiggins@google.com> <20190813043140.67FF320644@mail.kernel.org> Subject: Re: [PATCH v12 12/18] kunit: test: add tests for KUnit managed resources From: Stephen Boyd Date: Tue, 13 Aug 2019 10:07:12 -0700 Message-Id: <20190813170712.C89CA20679@mail.kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: Petr Mladek , "open list:DOCUMENTATION" , Peter Zijlstra , Amir Goldstein , dri-devel , Sasha Levin , Masahiro Yamada , Michael Ellerman , "open list:KERNEL SELFTEST FRAMEWORK" , shuah , Rob Herring , linux-nvdimm , Frank Rowand , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild , "Bird," Timothy" , Avinash Kondareddy ," linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Josh Poimboeuf , kunit-dev@googlegroups.com, Theodore Ts'o , Richard Weinberger , Greg KH , Randy Dunlap , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org, Kevin Hilman List-ID: Quoting Brendan Higgins (2019-08-13 00:57:33) > On Mon, Aug 12, 2019 at 9:31 PM Stephen Boyd wrote: > > > > BTW, maybe kunit allocation APIs should > > fail the test if they fail to allocate in general. Unless we're unit > > testing failure to allocate problems. > > Yeah, I thought about that. I wasn't sure how people would feel about > it, and I thought it would be a pain to tease out all the issues > arising from aborting in different contexts when someone might not > expect it. > > I am thinking later we can have kunit_kmalloc_or_abort variants? And > then we can punt this issue to a later time? > Sure. Sounds good. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm