Re: [ndctl PATCH] libdaxctl: fix memory leaks with daxctl_memory objects

[Ira Weiny <ira.weiny@intel.com>]

On Wed, Oct 02, 2019 at 05:01:24PM -0700, 'Vishal Verma' wrote:
> On Tue, 2019-10-01 at 16:19 -0700, Ira Weiny wrote:
> > 
> > > diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c
> > > index 8abfd64..639224c 100644
> > > --- a/daxctl/lib/libdaxctl.c
> > > +++ b/daxctl/lib/libdaxctl.c
> > > @@ -204,8 +204,9 @@ DAXCTL_EXPORT void daxctl_region_get_uuid(struct daxctl_region *region, uuid_t u
> > >  
> > >  static void free_mem(struct daxctl_dev *dev)
> > >  {
> > > -	if (dev && dev->mem) {
> > > +	if (dev->mem) {
> > 
> > There is a comment in daxctl_dev_disable() which says:
> > 
> >         /* If there is a memory object, first free that */
> > 
> > I'm 100% sure that dev can't be NULL there.  So that comment no longer applies.
> > 
> > May want to remove that comment.
> > 
> Hm, I'm not sure I follow.
> 
> Yes, dev can't be null there, but 'mem' can me. Hence the comment saying
> if /mem/ is present, free it.
> 
> The check in free_mem() only checks for non-NULL mem too.

Ah yea ok.  Sorry
Ira
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org