Re: [RFC PATCH 0/7] xfs: add reflink & dedupe support for fsdax.

Dave Chinner
2019-08-05T00:25:58Z

On Thu, Aug 01, 2019 at 09:37:04AM +0800, Shiyang Ruan wrote:
>
>
> On 8/1/19 4:33 AM, Goldwyn Rodrigues wrote:
> > On 19:49 31/07, Shiyang Ruan wrote:
> > > This patchset aims to take care of this issue to make reflink and dedupe
> > > work correctly in XFS.
> > >
> > > It is based on Goldwyn's patchsets: "v4 Btrfs dax support" and "Btrfs
> > > iomap". I picked up some patches related and made a few fix to make it
> > > basically works fine.
> > >
> > > For dax framework:
> > > 1. adapt to the latest change in iomap.
> > >
> > > For XFS:
> > > 1. report the source address and set IOMAP_COW type for those write
> > > operations that need COW.
> > > 2. update extent list at the end.
> > > 3. add file contents comparison function based on dax framework.
> > > 4. use xfs_break_layouts() to support dax.
> >
> > Shiyang,
> >
> > I think you used the older patches which does not contain the iomap changes
> > which would call iomap_begin() with two iomaps. I have it in the btrfs-iomap
>
> Oh, Sorry for my carelessness. This patchset is built on your "Btrfs
> iomap". I didn't point it out in cover letter.
>
> > branch and plan to update it today. It is built on v5.3-rcX, so it should
> > contain the changes which moves the iomap code to the different directory.
> > I will build the dax patches on top of that.
> > However, we are making a big dependency chain here
> Don't worry. It's fine for me. I'll follow your updates.

Hi Shiyang,

I'll wait for you to update your patches on top of the latest btrfs
patches before looking at this any futher. it would be good to get
a set of iomap infrastructure patches separated from the btrfs
patchsets so could have them both built from a common patchset.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com