From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C31B3C43215 for ; Thu, 14 Nov 2019 12:32:42 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B27320709 for ; Thu, 14 Nov 2019 12:32:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B27320709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from new-ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 11785100DC3CF; Thu, 14 Nov 2019 04:34:13 -0800 (PST) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver= Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 71626100DC3CB for ; Thu, 14 Nov 2019 04:34:10 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 56E7C68B05; Thu, 14 Nov 2019 13:32:37 +0100 (CET) Date: Thu, 14 Nov 2019 13:32:37 +0100 From: Christoph Hellwig To: Dan Williams Subject: Re: [PATCH v2] mm: Cleanup __put_devmap_managed_page() vs ->page_free() Message-ID: <20191114123237.GA31940@lst.de> References: <157371938291.3055029.12105459405251950438.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <157371938291.3055029.12105459405251950438.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Message-ID-Hash: OUTAOKHFYFD2U45IGUWBEVU7PUPC6PEJ X-Message-ID-Hash: OUTAOKHFYFD2U45IGUWBEVU7PUPC6PEJ X-MailFrom: hch@lst.de X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: jhubbard@nvidia.com, Jan Kara , Christoph Hellwig , =?iso-8859-1?B?Suly9G1l?= Glisse , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Nov 14, 2019 at 12:20:13AM -0800, Dan Williams wrote: > + if (count > 1) { > + /* still busy */ > + return; > + } else if (count == 0) { > + /* only triggered by the dev_pagemap shutdown path */ > + __put_page(page); > + return; > + } else if (!is_device_private_page(page)) { > + /* notify page idle for dax */ > + wake_up_var(&page->_refcount); > + return; > + } No need for an else after a return. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org