From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [bug report] libnvdimm, nvdimm: dimm driver and base libnvdimm device-driver infrastructure
Date: Wed, 5 Feb 2020 22:28:06 +0300 [thread overview]
Message-ID: <20200205192806.GE24804@kadam> (raw)
In-Reply-To: <CAPcyv4jkTHeS2zTmYRoFi+evMemhmMkvPVcsBOQGXinGq6JyiQ@mail.gmail.com>
On Wed, Feb 05, 2020 at 11:16:22AM -0800, Dan Williams wrote:
> Ugh, sorry I thought you were pointing out that there's too many
> put_device() not the use after free. Yes, the use after free is a bug
> that needs fixing.
I am complaining about the device_puts... If we call device_put()
twice then it cause a problem in __nvdimm_create()
drivers/nvdimm/dimm_devs.c
506 nvdimm->sec.flags = nvdimm_security_flags(nvdimm, NVDIMM_USER);
507 nvdimm->sec.ext_flags = nvdimm_security_flags(nvdimm, NVDIMM_MASTER);
508 nd_device_register(dev);
509
510 return nvdimm;
^^^^^^
If we call device_put() twice then we this pointer within 4 seconds.
511 }
The fix is probably to make nd_device_register() return an error code so
we can do:
ret = nd_device_register(dev);
if (ret) {
device_put(&nvdimm->dev);
return NULL;
}
return nvdimm;
regards,
dan carpenter
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-02-05 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 12:38 [bug report] libnvdimm, nvdimm: dimm driver and base libnvdimm device-driver infrastructure Dan Carpenter
2020-02-05 17:47 ` Dan Williams
2020-02-05 18:10 ` Dan Carpenter
2020-02-05 18:23 ` Dan Williams
2020-02-05 19:08 ` Dan Carpenter
2020-02-05 19:16 ` Dan Williams
2020-02-05 19:28 ` Dan Carpenter [this message]
2020-02-05 20:04 ` Dan Williams
2020-02-05 20:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205192806.GE24804@kadam \
--to=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox