From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=DATE_IN_PAST_12_24, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77832C3B18F for ; Fri, 14 Feb 2020 09:42:12 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3215820873 for ; Fri, 14 Feb 2020 09:42:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3215820873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 07C2410FC33ED; Fri, 14 Feb 2020 01:45:29 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=195.135.220.15; helo=mx2.suse.de; envelope-from=jack@suse.cz; receiver= Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CC34D10FC33EA for ; Fri, 14 Feb 2020 01:45:26 -0800 (PST) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 00004ACC6; Fri, 14 Feb 2020 09:42:07 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 7AD7D1E0D3F; Thu, 13 Feb 2020 21:58:43 +0100 (CET) Date: Thu, 13 Feb 2020 21:58:43 +0100 From: Jan Kara To: Dan Williams Subject: Re: [PATCH] tools/testing/nvdimm: Fix compilation failure without CONFIG_DEV_DAX_PMEM_COMPAT Message-ID: <20200213205843.GA6600@quack2.suse.cz> References: <20200123154720.12097-1-jack@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Message-ID-Hash: B2FI7R7QG5FVHDFKTBW5XDOELNFE777Y X-Message-ID-Hash: B2FI7R7QG5FVHDFKTBW5XDOELNFE777Y X-MailFrom: jack@suse.cz X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Jan Kara , linux-nvdimm X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed 12-02-20 12:49:41, Dan Williams wrote: > On Wed, Feb 12, 2020 at 6:04 AM Jeff Moyer wrote: > > > > Jan Kara writes: > > > > > When a kernel is configured without CONFIG_DEV_DAX_PMEM_COMPAT, the > > > compilation of tools/testing/nvdimm fails with: > > > > > > Building modules, stage 2. > > > MODPOST 11 modules > > > ERROR: "dax_pmem_compat_test" [tools/testing/nvdimm/test/nfit_test.ko] undefined! > > > > > > Fix the problem by calling dax_pmem_compat_test() only if the kernel has > > > the required functionality. > > > > > > Signed-off-by: Jan Kara > > > > What's the motivation? Is this just to fix randconfig builds? The > > reason I ask is that the test suite will expect to be able to find the > > dax_pmem_compat module, so it doesn't make sense to me to disable those > > tests only in the kernel as you'll hit a problem when running the tests > > anyway. > > Yeah, at a minimum you'd also need to go fix up nfit_test_init() to > not check for the dax_pmem_compat module: > > https://github.com/pmem/ndctl/blob/master/test/core.c#L119 OK. > > But, I understand if you want to prevent build bots from hitting > > compilation failures due to this. > > Hmm, build bots would only hit what's covered by > CONFIG_NVDIMM_TEST_BUILD, and that's only building > tools/testing/nvdimm/test/iomap.c. > > Jan, were you just looking to use nfit_test outside of running the > ndctl test suites? Or was this just a drive-by compilation test? The problem is following: We build our distro kernels without CONFIG_DEV_DAX_PMEM_COMPAT because we don't need that functionality. And Jing Han (from Intel ;) is now complaining that he cannot compile and run the ndctl testsuite on our kernels... It seems stupid to enable that config option for all distro users just to be able to run the testsuite but OTOH it would be neat to be able to run the testsuite with stock distro config. Honza -- Jan Kara SUSE Labs, CR _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org