From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F81C7619D for ; Mon, 17 Feb 2020 08:16:58 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 678C820725 for ; Mon, 17 Feb 2020 08:16:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 678C820725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 0BF8A10FC3370; Mon, 17 Feb 2020 00:20:15 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=195.135.220.15; helo=mx2.suse.de; envelope-from=jack@suse.cz; receiver= Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 151C510FC319F for ; Mon, 17 Feb 2020 00:20:13 -0800 (PST) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5ABEDBA1B; Mon, 17 Feb 2020 08:16:55 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id B73FB1E0D47; Mon, 17 Feb 2020 09:16:54 +0100 (CET) Date: Mon, 17 Feb 2020 09:16:54 +0100 From: Jan Kara To: Dan Williams Subject: Re: [PATCH] tools/testing/nvdimm: Fix compilation failure without CONFIG_DEV_DAX_PMEM_COMPAT Message-ID: <20200217081654.GA12032@quack2.suse.cz> References: <20200123154720.12097-1-jack@suse.cz> <20200213205843.GA6600@quack2.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Message-ID-Hash: CLMZMO7GKNJCEN3IJCIDYDFN42I2E4SL X-Message-ID-Hash: CLMZMO7GKNJCEN3IJCIDYDFN42I2E4SL X-MailFrom: jack@suse.cz X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Jan Kara , linux-nvdimm X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri 14-02-20 08:13:59, Dan Williams wrote: > On Fri, Feb 14, 2020 at 1:42 AM Jan Kara wrote: > > > > But, I understand if you want to prevent build bots from hitting > > > > compilation failures due to this. > > > > > > Hmm, build bots would only hit what's covered by > > > CONFIG_NVDIMM_TEST_BUILD, and that's only building > > > tools/testing/nvdimm/test/iomap.c. > > > > > > Jan, were you just looking to use nfit_test outside of running the > > > ndctl test suites? Or was this just a drive-by compilation test? > > > > The problem is following: We build our distro kernels without > > CONFIG_DEV_DAX_PMEM_COMPAT because we don't need that functionality. And > > Jing Han (from Intel ;) is now complaining that he cannot compile and run > > the ndctl testsuite on our kernels... It seems stupid to enable that config > > option for all distro users just to be able to run the testsuite but OTOH > > it would be neat to be able to run the testsuite with stock distro > > config. > > Sounds good, minus the fact that Jing and I were not on the same page. > I'll send the ndctl fixup. Thanks! Honza -- Jan Kara SUSE Labs, CR _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org