From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF1EC4363A for ; Tue, 27 Oct 2020 07:11:26 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA18021556 for ; Tue, 27 Oct 2020 07:11:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA18021556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5DD0015129241; Tue, 27 Oct 2020 00:11:25 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=ira.weiny@intel.com; receiver= Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 90B3D1512923E for ; Tue, 27 Oct 2020 00:11:22 -0700 (PDT) IronPort-SDR: fG+FP8Gw6IZhhL/LyLWmUMdmTmO97qKNmDIYd1+7VYfS3uFSq82LtZdTn+sbpHKbUTFBq3VGKB ztvTI3jyOtMw== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="252736635" X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="252736635" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 00:11:21 -0700 IronPort-SDR: yxpbvNXqR2ZH8VELzLKdveHPiLfaOg4FP6eotaVuipb+Li1gAU22E4WQmw0d7T2iCHSawR5QAw LXDe2LDQzbVA== X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="535680174" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 00:11:15 -0700 Date: Tue, 27 Oct 2020 00:11:14 -0700 From: Ira Weiny To: Thomas Gleixner Subject: Re: [PATCH 07/10] x86/entry: Pass irqentry_state_t by reference Message-ID: <20201027071114.GN534324@iweiny-DESK2.sc.intel.com> References: <20201022222701.887660-1-ira.weiny@intel.com> <20201022222701.887660-8-ira.weiny@intel.com> <87y2jw4ne6.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87y2jw4ne6.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.11.1 (2018-12-01) Message-ID-Hash: OT4SHTXZJQ6FQH27ENZYRVZ34T5MWYJF X-Message-ID-Hash: OT4SHTXZJQ6FQH27ENZYRVZ34T5MWYJF X-MailFrom: ira.weiny@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Ingo Molnar , Borislav Petkov , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, Dave Hansen , Andrew Morton , Fenghua Yu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Oct 23, 2020 at 11:56:33PM +0200, Thomas Gleixner wrote: > On Thu, Oct 22 2020 at 15:26, ira weiny wrote: > > From: Ira Weiny > > > > In preparation for adding PKS information to struct irqentry_state_t > > change all call sites and usages to pass the struct by reference > > instead of by value. > > This still does not explain WHY you need to do that. 'Preparation' is a > pretty useless information. > > What is the actual reason for this? Just because PKS information feels > better that way? > > Also what is PKS information? Changelogs have to make sense on their own > and not only in the context of a larger series of changes. I've reworded this to explain the addition of new members which would make passing by value less efficient with additional structure changes being added later in the series. > > > While we are editing the call sites it is a good time to standardize on > > the name 'irq_state'. > > While at it change all usage sites to consistently use the variable > name 'irq_state'. > > Or something like that. See Documentation/process/... Sorry, bad habit. Fixed. Thanks, Ira > > Thanks, > > tglx > _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org