From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9842CC433ED for ; Sat, 8 May 2021 17:51:39 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2512E610FA for ; Sat, 8 May 2021 17:51:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2512E610FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E8AC1100EBB96; Sat, 8 May 2021 10:51:38 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=rppt@kernel.org; receiver= Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3A98A100ED48C for ; Sat, 8 May 2021 10:51:35 -0700 (PDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 510B660FD9; Sat, 8 May 2021 17:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620496293; bh=O0h+6YLIy3dP7dPfFuX77EmGOJ47Y0nxessyteHlFwI=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=BgjMRsti57RVhgQLssViPv/S1jke0ZLAX2VHcQ+zhhqyTEdCGfsx+Hm+xfLYc3gK2 febH6fPKLW1GSvaeOKdWLiFT7mRIPWWr75WERrbhc2iP5XTwEvaWUeT5C35mmGej+K 2PcdNk2F7zAnv7ool7i0GQtmQlR0QvCGCi54y4VUmuqProi5oDD31BiSBZqMLtCS+M dWjPvGC1v25ePTrlu9IDnx7VhIslSf3ux2o+IJF65VRAkOiztZHjJqudkvMw1FjRre H5PnmFZFJ4SyMu1vYvNmyyo21lFpuMxuRrcIpAD5pLR8VMdJxDTCRJjWYRX6B4pi1c 1jcXpeCGiqVyA== Date: Sat, 08 May 2021 20:51:23 +0300 User-Agent: K-9 Mail for Android In-Reply-To: References: <20210420150049.14031-1-rppt@kernel.org> <20210420150049.14031-3-rppt@kernel.org> MIME-Version: 1.0 Subject: Re: [PATCH v3 2/2] secretmem: optimize page_is_secretmem() To: Matthew Wilcox Message-Id: <20210508175132.510B660FD9@mail.kernel.org> From: rppt@kernel.org Message-ID-Hash: YPLKMGFZUAS3NXYJZY65EMKNALX3KXAF X-Message-ID-Hash: YPLKMGFZUAS3NXYJZY65EMKNALX3KXAF X-MailFrom: rppt@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Matthew Garrett , Mark Rutland , Michal Hocko , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , "Rafael J. Wysocki" , Rick Edgecombe , Roman Gushchin , Shakeel@ml01.01.org X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ,Shuah Khan ,Thomas Gleixner ,Tycho Andersen ,Will Deacon ,Yury Norov ,linux-api@vger.kernel.org,linux-arch@vger.kernel.org,linux-arm-kernel@lists.infradead.org,linux-fsdevel@vger.kernel.org,linux-mm@kvack.org,linux-kernel@vger.kernel.org,linux-kselftest@vger.kernel.org,linux-nvdimm@lists.01.org,linux-riscv@lists.infradead.org,x86@kernel.org,kernel test robot From: Mike Rapoport Message-ID: <48E0FD56-6084-48B0-A59C-D2E2BF40DDA2@kernel.org> On May 7, 2021 6:01:44 PM GMT+03:00, Matthew Wilcox wrote: >On Tue, Apr 20, 2021 at 06:00:49PM +0300, Mike Rapoport wrote: >> + mapping = (struct address_space *) >> + ((unsigned long)page->mapping & ~PAGE_MAPPING_FLAGS); >> + >> + if (mapping != page->mapping) >> + return false; >> + >> + return page->mapping->a_ops == &secretmem_aops; > >... why do you go back to page->mapping here? > > return mapping->a_ops == &secretmem_aops Ok -- Sincerely yours, Mike _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org