Linux-NVDIMM Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [PATCH v3 1/6] libnvdimm/namespace: Make namespace size validation arch dependent
Date: Sat, 11 Jan 2020 10:03:24 +0530	[thread overview]
Message-ID: <253f7f57-d27f-91f1-4e99-ff69a0e88084@linux.ibm.com> (raw)
In-Reply-To: <x49muavm4gx.fsf@segfault.boston.devel.redhat.com>

On 1/11/20 2:08 AM, Jeff Moyer wrote:
> Hi, Aneesh,
> 
> After applying this patch series, several of my namespaces no longer
> enumerate:
> 
> Before:
> 
> # ndctl list
> [
>    {
>      "dev":"namespace0.2",
>      "mode":"sector",
>      "size":106541672960,
>      "uuid":"ea1122b2-c219-424c-b09c-38a6e94a1042",
>      "sector_size":512,
>      "blockdev":"pmem0.2s"
>    },
>    {
>      "dev":"namespace0.1",
>      "mode":"fsdax",
>      "map":"dev",
>      "size":10567548928,
>      "uuid":"68b6746f-481a-4ae6-80b5-71d62176606c",
>      "sector_size":512,
>      "align":4096,
>      "blockdev":"pmem0.1"
>    },
>    {
>      "dev":"namespace0.0",
>      "mode":"fsdax",
>      "map":"dev",
>      "size":52850327552,
>      "uuid":"6d3a0199-5d9a-4fed-830d-e25249b70571",
>      "sector_size":512,
>      "align":2097152,
>      "blockdev":"pmem0"
>    }
> ]
> 
> After:
> 
> # ndctl list
> [
>    {
>      "dev":"namespace0.0",
>      "mode":"fsdax",
>      "map":"dev",
>      "size":52850327552,
>      "uuid":"6d3a0199-5d9a-4fed-830d-e25249b70571",
>      "sector_size":512,
>      "align":2097152,
>      "blockdev":"pmem0"
>    }
> ]
> 
> I won't have time to dig into it this week, but I wanted to mention it
> before Dan merged these patches.
> 
> I'll follow up next week with more information.
> 

dmesg should contain details  like

[    5.810939] nd_pmem namespace0.1: invalid size/SPA
[    5.810969] nd_pmem: probe of namespace0.1 failed with error -95

This is mostly due to the namespace start address not aligned to 
subsection size.

"namespace0.2" not having a 2MB aligned size which cause namespace 0.1 
start addr to be not aligned. Hence both the namespace are marked disabled.

-aneesh
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

  parent reply	other threads:[~2020-01-11  4:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  6:52 [PATCH v3 1/6] libnvdimm/namespace: Make namespace size validation arch dependent Aneesh Kumar K.V
2020-01-08  6:52 ` [PATCH v3 2/6] libnvdimm/namespace: Validate namespace start addr and size Aneesh Kumar K.V
2020-01-08  6:52 ` [PATCH v3 3/6] libnvdimm/namespace: Validate namespace size when creating new namespace Aneesh Kumar K.V
2020-01-08  6:52 ` [PATCH v3 4/6] libnvdimm/namespace: Add debug check while initializing namespace resource size Aneesh Kumar K.V
2020-01-08  6:52 ` [PATCH v3 5/6] libnvdimm/namespace: Align DPA based on arch restrictions Aneesh Kumar K.V
2020-01-08  6:52 ` [PATCH v3 6/6] libnvdimm/namespace: Expose arch specific supported size align value Aneesh Kumar K.V
2020-01-10 20:38 ` [PATCH v3 1/6] libnvdimm/namespace: Make namespace size validation arch dependent Jeff Moyer
2020-01-10 21:03   ` Dan Williams
2020-01-11  4:29     ` Aneesh Kumar K.V
2020-01-11  4:33   ` Aneesh Kumar K.V [this message]
2020-01-11  4:55     ` Dan Williams
2020-01-13 15:08       ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=253f7f57-d27f-91f1-4e99-ff69a0e88084@linux.ibm.com \
    --to=aneesh.kumar@linux.ibm.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox