From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 288A421A07A80 for ; Fri, 28 Sep 2018 02:28:13 -0700 (PDT) From: David Howells In-Reply-To: <26387.1538124354@warthog.procyon.org.uk> References: <26387.1538124354@warthog.procyon.org.uk> <153799483810.71621.11639561453544624699.stgit@djiang5-desk3.ch.intel.com> <153799466529.71621.10728628542331983376.stgit@djiang5-desk3.ch.intel.com> Subject: Re: [PATCH v10 06/12] nfit/libnvdimm: add set passphrase support for Intel nvdimms MIME-Version: 1.0 Content-ID: <28714.1538126890.1@warthog.procyon.org.uk> Date: Fri, 28 Sep 2018 10:28:10 +0100 Message-ID: <28715.1538126890@warthog.procyon.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" Cc: alison.schofield@intel.com, keescook@chromium.org, linux-nvdimm@lists.01.org, ebiggers3@gmail.com, dhowells@redhat.com, keyrings@vger.kernel.org List-ID: David Howells wrote: > if (sscanf(buf, "%" __stringify(SEC_CMD_SIZE) "s %u %u", ...) == 3) Actually, that would need to be "SEC_CMD_SIZE - 1" - which might get stringified as-is. David _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm