From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A2BC433DF for ; Mon, 13 Jul 2020 14:35:46 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28E8D206F4 for ; Mon, 13 Jul 2020 14:35:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28E8D206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id ED6D1117A733A; Mon, 13 Jul 2020 07:35:45 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=195.135.220.15; helo=mx2.suse.de; envelope-from=hare@suse.de; receiver= Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DB260117A732C for ; Mon, 13 Jul 2020 07:35:43 -0700 (PDT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0AAB4AC24; Mon, 13 Jul 2020 14:35:44 +0000 (UTC) Subject: Re: [PATCH] libnvdimm: call devm_namespace_disable() on error To: Santosh Sivaraj , Dan Williams References: <20200703111856.40280-1-hare@suse.de> <87zh89qmaq.fsf@santosiv.in.ibm.com> From: Hannes Reinecke Message-ID: <3ee5b9ed-a42d-425b-1f0e-ee1591cd5cec@suse.de> Date: Mon, 13 Jul 2020 16:35:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <87zh89qmaq.fsf@santosiv.in.ibm.com> Content-Language: en-US Message-ID-Hash: 26GD2DXA5Y7RU4FGLRXIGCV7IH425SGV X-Message-ID-Hash: 26GD2DXA5Y7RU4FGLRXIGCV7IH425SGV X-MailFrom: hare@suse.de X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-nvdimm@lists.01.org X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 T24gNy85LzIwIDc6MzkgQU0sIFNhbnRvc2ggU2l2YXJhaiB3cm90ZToNCj4gSGkgSGFubmVzLA0K PiANCj4gSGFubmVzIFJlaW5lY2tlIDxoYXJlQHN1c2UuZGU+IHdyaXRlczoNCj4gDQo+PiBPbmNl IGRldm1fbmFtZXNwYWNlX2VuYWJsZSgpIGhhcyBiZWVuIGNhbGxlZCB0aGUgZXJyb3IgcGF0aCBp biB0aGUNCj4+IGNhbGxpbmcgZnVuY3Rpb24gd2lsbCBub3QgY2FsbCBkZXZtX25hbWVzcGFjZV9k aXNhYmxlKCksIGxlYXZpbmcgdGhlDQo+PiBuYW1lc3BhY2UgZW5hYmxlZCBvbiBlcnJvci4NCj4+ DQo+PiBTaWduZWQtb2ZmLWJ5OiBIYW5uZXMgUmVpbmVja2UgPGhhcmVAc3VzZS5kZT4NCj4+IC0t LQ0KPj4gICBkcml2ZXJzL2RheC9wbWVtL2NvcmUuYyAgIHwgIDIgKy0NCj4+ICAgZHJpdmVycy9u dmRpbW0vYnR0LmMgICAgICB8ICA1ICsrKystDQo+PiAgIGRyaXZlcnMvbnZkaW1tL2NsYWltLmMg ICAgfCAgOCArKysrKysrLQ0KPj4gICBkcml2ZXJzL252ZGltbS9wZm5fZGV2cy5jIHwgIDEgKw0K Pj4gICBkcml2ZXJzL252ZGltbS9wbWVtLmMgICAgIHwgMjAgKysrKysrKysrKy0tLS0tLS0tLS0N Cj4+ICAgNSBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkN Cj4+DQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kYXgvcG1lbS9jb3JlLmMgYi9kcml2ZXJzL2Rh eC9wbWVtL2NvcmUuYw0KPj4gaW5kZXggMmJlZGY4NDE0ZmZmLi40YjI2NDM0ZjBhY2EgMTAwNjQ0 DQo+PiAtLS0gYS9kcml2ZXJzL2RheC9wbWVtL2NvcmUuYw0KPj4gKysrIGIvZHJpdmVycy9kYXgv cG1lbS9jb3JlLmMNCj4+IEBAIC0zMSw5ICszMSw5IEBAIHN0cnVjdCBkZXZfZGF4ICpfX2RheF9w bWVtX3Byb2JlKHN0cnVjdCBkZXZpY2UgKmRldiwgZW51bSBkZXZfZGF4X3N1YnN5cyBzdWJzeXMp DQo+PiAgIAlpZiAocmMpDQo+PiAgIAkJcmV0dXJuIEVSUl9QVFIocmMpOw0KPj4gICAJcmMgPSBu dmRpbW1fc2V0dXBfcGZuKG5kX3BmbiwgJnBnbWFwKTsNCj4+ICsJZGV2bV9uYW1lc3BhY2VfZGlz YWJsZShkZXYsIG5kbnMpOw0KPj4gICAJaWYgKHJjKQ0KPj4gICAJCXJldHVybiBFUlJfUFRSKHJj KTsNCj4+IC0JZGV2bV9uYW1lc3BhY2VfZGlzYWJsZShkZXYsIG5kbnMpOw0KPj4gICANCj4+ICAg CS8qIHJlc2VydmUgdGhlIG1ldGFkYXRhIGFyZWEsIGRldmljZS1kYXggd2lsbCByZXNlcnZlIHRo ZSBkYXRhICovDQo+PiAgIAlwZm5fc2IgPSBuZF9wZm4tPnBmbl9zYjsNCj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL252ZGltbS9idHQuYyBiL2RyaXZlcnMvbnZkaW1tL2J0dC5jDQo+PiBpbmRleCA0 OGU5ZDE2OWI2ZjkuLmJkNDc0N2YyYzk5YiAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMvbnZkaW1t L2J0dC5jDQo+PiArKysgYi9kcml2ZXJzL252ZGltbS9idHQuYw0KPj4gQEAgLTE3MDQsMTMgKzE3 MDQsMTYgQEAgaW50IG52ZGltbV9uYW1lc3BhY2VfYXR0YWNoX2J0dChzdHJ1Y3QgbmRfbmFtZXNw YWNlX2NvbW1vbiAqbmRucykNCj4+ICAgCQlkZXZfZGJnKCZuZF9idHQtPmRldiwgIiVzIG11c3Qg YmUgYXQgbGVhc3QgJWxkIGJ5dGVzXG4iLA0KPj4gICAJCQkJZGV2X25hbWUoJm5kbnMtPmRldiks DQo+PiAgIAkJCQlBUkVOQV9NSU5fU0laRSArIG5kX2J0dC0+aW5pdGlhbF9vZmZzZXQpOw0KPj4g KwkJZGV2bV9uYW1lc3BhY2VfZGlzYWJsZSgmbmRfYnR0LT5kZXYsIG5kbnMpOw0KPj4gICAJCXJl dHVybiAtRU5YSU87DQo+PiAgIAl9DQo+PiAgIAluZF9yZWdpb24gPSB0b19uZF9yZWdpb24obmRf YnR0LT5kZXYucGFyZW50KTsNCj4+ICAgCWJ0dCA9IGJ0dF9pbml0KG5kX2J0dCwgcmF3c2l6ZSwg bmRfYnR0LT5sYmFzaXplLCBuZF9idHQtPnV1aWQsDQo+PiAgIAkJCW5kX3JlZ2lvbik7DQo+PiAt CWlmICghYnR0KQ0KPj4gKwlpZiAoIWJ0dCkgew0KPj4gKwkJZGV2bV9uYW1lc3BhY2VfZGlzYWJs ZSgmbmRfYnR0LT5kZXYsIG5kbnMpOw0KPj4gICAJCXJldHVybiAtRU5PTUVNOw0KPj4gKwl9DQo+ PiAgIAluZF9idHQtPmJ0dCA9IGJ0dDsNCj4+ICAgDQo+PiAgIAlyZXR1cm4gMDsNCj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL252ZGltbS9jbGFpbS5jIGIvZHJpdmVycy9udmRpbW0vY2xhaW0uYw0K Pj4gaW5kZXggNDU5NjRhY2JhOTQ0Li4xNWZkMWI5MmQzMmYgMTAwNjQ0DQo+PiAtLS0gYS9kcml2 ZXJzL252ZGltbS9jbGFpbS5jDQo+PiArKysgYi9kcml2ZXJzL252ZGltbS9jbGFpbS5jDQo+PiBA QCAtMzE0LDEyICszMTQsMTggQEAgaW50IGRldm1fbnNpb19lbmFibGUoc3RydWN0IGRldmljZSAq ZGV2LCBzdHJ1Y3QgbmRfbmFtZXNwYWNlX2lvICpuc2lvLA0KPj4gICAJfQ0KPj4gICANCj4+ICAg CW5kbnMtPnJ3X2J5dGVzID0gbnNpb19yd19ieXRlczsNCj4+IC0JaWYgKGRldm1faW5pdF9iYWRi bG9ja3MoZGV2LCAmbnNpby0+YmIpKQ0KPj4gKwlpZiAoZGV2bV9pbml0X2JhZGJsb2NrcyhkZXYs ICZuc2lvLT5iYikpIHsNCj4+ICsJCWRldm1fcmVsZWFzZV9tZW1fcmVnaW9uKGRldiwgcmVzLT5z dGFydCwgc2l6ZSk7DQo+PiAgIAkJcmV0dXJuIC1FTk9NRU07DQo+PiArCX0NCj4+ICAgCW52ZGlt bV9iYWRibG9ja3NfcG9wdWxhdGUodG9fbmRfcmVnaW9uKG5kbnMtPmRldi5wYXJlbnQpLCAmbnNp by0+YmIsDQo+PiAgIAkJCSZuc2lvLT5yZXMpOw0KPj4gICANCj4+ICAgCW5zaW8tPmFkZHIgPSBk ZXZtX21lbXJlbWFwKGRldiwgcmVzLT5zdGFydCwgc2l6ZSwgQVJDSF9NRU1SRU1BUF9QTUVNKTsN Cj4+ICsJaWYgKElTX0VSUihuc2lvLT5hZGRyKSkgew0KPj4gKwkJZGV2bV9leGl0X2JhZGJsb2Nr cyhkZXYsICZuc2lvLT5iYik7DQo+PiArCQlkZXZtX3JlbGVhc2VfbWVtX3JlZ2lvbihkZXYsIHJl cy0+c3RhcnQsIHNpemUpOw0KPj4gKwl9DQo+PiAgIA0KPj4gICAJcmV0dXJuIFBUUl9FUlJfT1Jf WkVSTyhuc2lvLT5hZGRyKTsNCj4+ICAgfQ0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbnZkaW1t L3Bmbl9kZXZzLmMgYi9kcml2ZXJzL252ZGltbS9wZm5fZGV2cy5jDQo+PiBpbmRleCAzNGRiNTU3 ZGJhZDEuLjlmYWE5MjY2MjY0MyAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMvbnZkaW1tL3Bmbl9k ZXZzLmMNCj4+ICsrKyBiL2RyaXZlcnMvbnZkaW1tL3Bmbl9kZXZzLmMNCj4+IEBAIC00MDgsNiAr NDA4LDcgQEAgc3RhdGljIGludCBuZF9wZm5fY2xlYXJfbWVtbWFwX2Vycm9ycyhzdHJ1Y3QgbmRf cGZuICpuZF9wZm4pDQo+PiAgIAkJCQluc29mZiArPSBjaHVuazsNCj4+ICAgCQkJfQ0KPj4gICAJ CQlpZiAocmMpIHsNCj4+ICsJCQkJZGV2bV9uYW1lc3BhY2VfZGlzYWJsZSgmbmRfcGZuLT5kZXYs IG5kbnMpOw0KPiANCj4gVGhlIGRpc2FibGUgaGVyZSBzZWVtcyB0byBiZSB3cm9uZy4NCj4gDQo+ IFRoaXMgZnVuY3Rpb24gY2FsbGVkIGZyb20gdGhlIHBtZW1fYXR0YWNoX2Rpc2sgcGF0aCwgd2hl cmUgaXRzIGV4cGVjdGVkIHRoZQ0KPiBuYW1lc3BhY2UgaXMgZW5hYmxlZCBhZnRlciB0aGUgc2V0 dXBfcGZuLiBBbHNvIGluIGNhc2Ugb2YgYW4gZXJyb3IsIHdlIGRvDQo+IGFub3RoZXIgZGlzYWJs ZSBpbiBwbWVtX2F0dGFjaF9kaXNrLg0KDQpPaC4gQ29ycmVjdC4gV2lsbCBiZSBmaXhpbmcgaXQg dXAuDQoNCkNoZWVycywNCg0KSGFubmVzDQotLSANCkRyLiBIYW5uZXMgUmVpbmVja2UgICAgICAg ICAgICBUZWFtbGVhZCBTdG9yYWdlICYgTmV0d29ya2luZw0KaGFyZUBzdXNlLmRlICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICs0OSA5MTEgNzQwNTMgNjg4DQpTVVNFIFNvZnR3YXJlIFNv bHV0aW9ucyBHbWJILCBNYXhmZWxkc3RyLiA1LCA5MDQwOSBOw7xybmJlcmcNCkhSQiAzNjgwOSAo QUcgTsO8cm5iZXJnKSwgR2VzY2jDpGZ0c2bDvGhyZXI6IEZlbGl4IEltZW5kw7ZyZmZlcgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1udmRpbW0g bWFpbGluZyBsaXN0IC0tIGxpbnV4LW52ZGltbUBsaXN0cy4wMS5vcmcKVG8gdW5zdWJzY3JpYmUg c2VuZCBhbiBlbWFpbCB0byBsaW51eC1udmRpbW0tbGVhdmVAbGlzdHMuMDEub3JnCg==