Re: [ndctl PATCH V2 0/8] fix serverl issues reported by Coverity

[Zhiqiang Liu <liuzhiqiang26@huawei.com>]

On 2020/12/17 11:41, Verma, Vishal L wrote:
> On Wed, 2020-11-25 at 09:00 +0800, Zhiqiang Liu wrote:
>> Changes: V1->V2
>> - add one empty line in 1/8 patch as suggested by Jeff Moyer <jmoyer@redhat.com>.
>>
>>
>> Recently, we use Coverity to analysis the ndctl package.
>> Several issues should be resolved to make Coverity happy.
>>
>> Zhiqiang Liu (8):
>>   namespace: check whether pfn|dax|btt is NULL in setup_namespace
>>   lib/libndctl: fix memory leakage problem in add_bus
>>   libdaxctl: fix memory leakage in add_dax_region()
>>   dimm: fix potential fd leakage in dimm_action()
>>   util/help: check whether strdup returns NULL in exec_man_konqueror
>>   lib/inject: check whether cmd is created successfully
>>   libndctl: check whether ndctl_btt_get_namespace returns NULL in
>>     callers
>>   namespace: check whether seed is NULL in validate_namespace_options
>>
>>  daxctl/lib/libdaxctl.c |  3 +++
>>  ndctl/dimm.c           | 12 +++++++-----
>>  ndctl/lib/inject.c     |  8 ++++++++
>>  ndctl/lib/libndctl.c   |  1 +
>>  ndctl/namespace.c      | 23 ++++++++++++++++++-----
>>  test/libndctl.c        | 16 +++++++++++-----
>>  test/parent-uuid.c     |  2 +-
>>  util/help.c            |  8 +++++++-
>>  util/json.c            |  3 +++
>>  9 files changed, 59 insertions(+), 17 deletions(-)
>>
> Hi Zhiquiang,
> 
> The patches look good, and I've applied them for v71. However one thing
> to note:
> 
> If you're sending a v2, it is preferable to respin the whole series,
> even if you're only changing a subset of (even a single) patch in the
> series. That allows tools like 'b4' to just Do The Right Thing, and make
> sure all the latest patches are grabbed.
> 
> In this case, especially, your cover letter promises 8 patches (0/8),
> but there is only one that follows. This confuses 'b4':
> 
>    ERROR: missing [2/8]!
>    ERROR: missing [3/8]!
>    ERROR: missing [4/8]!
>    ...etc
> 
> I've fixed it up manually for this, but just some things to consider for
> the future.
> 

Thanks for the suggestion。

Regards
Zhiqiang Liu

> Thanks,
> -Vishal
> 
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org