From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E15C433DF for ; Fri, 14 Aug 2020 22:52:27 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59BC2214F1 for ; Fri, 14 Aug 2020 22:52:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="n4RjppD3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59BC2214F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 2019E131A5189; Fri, 14 Aug 2020 15:52:27 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=vishal.l.verma@intel.com; receiver= Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 24867131A5187 for ; Fri, 14 Aug 2020 15:52:24 -0700 (PDT) IronPort-SDR: l4bBCtgbIS0BxQ67jkKyIUYmZQ4iq6+PUjCt6GtVy0Yr0PgoUmRvsxsz4l0c/gB75CZUDjcH95 1a2oewKRMX6Q== X-IronPort-AV: E=McAfee;i="6000,8403,9713"; a="218826062" X-IronPort-AV: E=Sophos;i="5.76,313,1592895600"; d="scan'208";a="218826062" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2020 15:52:24 -0700 IronPort-SDR: QtYe4ERaVseq+kun6wFxk7mE42lBWQgAOOMGQ/RKzYPpmMR/E9NRIKE6J+A0D+pB2U5eTREaSG ZxdaSUyW4VUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,313,1592895600"; d="scan'208";a="440253926" Received: from unknown (HELO fmsmsx605.amr.corp.intel.com) ([10.18.84.215]) by orsmga004.jf.intel.com with ESMTP; 14 Aug 2020 15:52:23 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 14 Aug 2020 15:52:23 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 14 Aug 2020 15:52:23 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 14 Aug 2020 15:52:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=To0YaHOOomsZhiQeWcxHNRwWsI+EXy1N6Hcqb2qn9ycO3VGVKOYZnXj2bmwpd1f+IFM50w0gwQzMD8JpZfiSYF2S/YbZElTwLFagzDv9+P0NlvCTyu86a1j2dvzrBR0JyhP94UGIjP3WJ8Fz2F/G+oIhdNzilmhsojkIb+3Oj7Np+ayDHcb9D58RqH0osS4phEZTE69Qtg+9eEMi5eeC5N1COuvvrzgJVPpwzCwPOy2VJz6g0/uabsO5I7s9oKhEputWzlxVSD58QXzlAcywnQninhyH0OOBWyQES0HQ4gCaiGJEUidOZxHJKRh7V6EAYVPzDmnETWG/qDA09netyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wGjKIYh2MkKStzQgtUxKeRMmPzuXeAHwOfLWyTA/tmk=; b=Bpw5dQ9Nk5XhMpXid5zzJHO9sMdHaXpejQ9wGjFvZly8aVvVAkax6EgWUaJCa+vcyRZJHCpWaqdSUO4a8F52er2LvcKckKoqMijfsXw4ePBdYQKE0XO5dFVpEpwIFOvPjEuqve3vK5HS+z6VN9Snfy9cvoH0+cYR7TdUOjYN//YF4lRBL4f8B1F+SqP8cGKUTT+EW/qN3aqB2q38TZZU6urvN74V4T0FJmBQfBoZt/SrpkBMibIOj6DifXCBka9I+07ke7AiMJ+wWKcQr1smP64PYTk5vemACncpUkWv6M13js7kfbcHBrlI2ipTNVrGtO8RUzfo6Xpb45cmrFinuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wGjKIYh2MkKStzQgtUxKeRMmPzuXeAHwOfLWyTA/tmk=; b=n4RjppD397tWb8PWRfhm41k6ik572CTqRFe4zsu1oRRJfmSHX89tMaGfY2Mp/sHPPASozmnIDw1bkRJTbxrYXamQLpxjxyluYr9jHVJmTea9f1PLuJy1Mn0n/KZ6mwOzNIh6/MR0UhtmbI6w2RyI+mKP0xSyxfX/mj1cnRqPLnA= Received: from BYAPR11MB3448.namprd11.prod.outlook.com (2603:10b6:a03:76::21) by BYAPR11MB3477.namprd11.prod.outlook.com (2603:10b6:a03:7c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.22; Fri, 14 Aug 2020 22:52:20 +0000 Received: from BYAPR11MB3448.namprd11.prod.outlook.com ([fe80::1084:a79c:5a4f:f115]) by BYAPR11MB3448.namprd11.prod.outlook.com ([fe80::1084:a79c:5a4f:f115%5]) with mapi id 15.20.3283.016; Fri, 14 Aug 2020 22:52:20 +0000 From: "Verma, Vishal L" To: "Williams, Dan J" , "rafael@kernel.org" , "wangqing@vivo.com" Subject: Re: [PATCH] acpi/nfit: Use kobj_to_dev() instead Thread-Topic: [PATCH] acpi/nfit: Use kobj_to_dev() instead Thread-Index: AQHWcRxpj/rghooL6kKeKlMDqnI2Vqk3vQEAgAB75oA= Date: Fri, 14 Aug 2020 22:52:20 +0000 Message-ID: <4e23dc722419e82d13772afc8e060d3203fd5a86.camel@intel.com> References: <1597286952-5706-1-git-send-email-wangqing@vivo.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5 (3.36.5-1.fc32) authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.55.39] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a00d7bb8-2ec7-411a-2f1f-08d840a4b39a x-ms-traffictypediagnostic: BYAPR11MB3477: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:359; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DWYKV3JQbRLXmKxuJ+/nUfCZCan8qUjV6dGBY1vAVxpF3KHPok9nW6hSDCQ3rxvf2P42x5cHga+WvxEPNhon3SPB+rH3B3WKuPeB6MyZoPo90SPrmjljAOPUCzvPOkNg12e0DEzVBVrxBGrYtuDKX7mT9eUrU/RFd9Nm/wIE6fLwWADR7qQJ0qjW/+xThLLCIwOf0K8r9MI5tIUhIrG2hqJzW4P+ovAJxTcNec4ElmEHfmNYHU3hC2h7EAmSyIebHaz2wylesMJn4Uo3RX+7Va+DqonplW5l4u9qGeKIfQQYZQKzvrmqXlVm+1IHxhey/osErU5w1ALAkMKLfq2qaw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3448.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(136003)(396003)(366004)(346002)(54906003)(4326008)(64756008)(8936002)(66946007)(2906002)(8676002)(2616005)(83380400001)(66476007)(66556008)(76116006)(186003)(66446008)(5660300002)(26005)(316002)(478600001)(6506007)(71200400001)(53546011)(36756003)(110136005)(86362001)(6486002)(6512007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 0gsoDWFQLB0VAe3pjYtdYnCr0dahtV0pz1UotAmdmvMRk20zrYmANobodV13was1+og5UEYifTLjSw8LfSpqWUbfi977gsqccpjOq5FtF6QZld5c57cDLXvuUOcfhAPYLLT4e728dnK0LQDYXy6GnBQJaKq27ZIeaE+DJTh1MGyGhHFko5PrDP+dJ32MFCcAYrz3x+/uDl1hWsEQZbvwGft2d4vk9jvc+gxzpI6IfhdMsPfpZ/WiQ3oEnSyb2xuwRbNesggie7a4M+EoXguQeddJLACfSWotBWeEvkuyYbFDoXXMdH0bEEJk8VVTlwVH6joef18AHbcQLwEoFrPIWDP1PMEdqIgFMKfhEobCd7xVFuh5Jjc1egCJRNJumnbsqRFdwezGGsqUxtNqIqC8Wq2Hw9vLEVLL6m/iuBCwA1BXhlPGOFpceina5cxTVHpw9CLYA78OUovkb80ignOeIHq8bv28vT14k2g/G3yltNeDey22+Z+IzoeyDwdLx3ClilKFzeXJA4zs5UtS6LlSWPWRPDyCaoaHKqXRgAZbSEK1Df0iMRfW+yyQHzV5TSPdlRQ7P18R1BqAbabDuZ/cN7nLuBgtH6wk0/pYxKG5GLfgFSE1lq9ialQEiH5gALYWttFVz6yGplIMT+Goe/2BPA== Content-ID: <1BEEF98980247B4E865FB383C7D5DC8D@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3448.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a00d7bb8-2ec7-411a-2f1f-08d840a4b39a X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2020 22:52:20.1747 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tf2wdwrIyOBfbLClc/QcJn8/SM0m//welJzAR0Gwp65GbqvyGZOIKlAff1tJpf/GQgstsErWl835zTtQ9jVgR95K2XRiF8q1an6e5nD3aVk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3477 X-OriginatorOrg: intel.com Message-ID-Hash: 5K4IITNEJDYM22HXOVSN42TGNQTXYTTR X-Message-ID-Hash: 5K4IITNEJDYM22HXOVSN42TGNQTXYTTR X-MailFrom: vishal.l.verma@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "linux-acpi@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "lenb@kernel.org" , "linux-kernel@vger.kernel.org" , "rjw@rjwysocki.net" X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, 2020-08-14 at 17:28 +0200, Rafael J. Wysocki wrote: > On Thu, Aug 13, 2020 at 4:54 AM Wang Qing wrote: > > Use kobj_to_dev() instead of container_of() > > > > Signed-off-by: Wang Qing > > LGTM > > Dan, any objections? Looks good to me - you can add: Acked-by: Vishal Verma > > > --- > > drivers/acpi/nfit/core.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > > index fa4500f..3bb350b > > --- a/drivers/acpi/nfit/core.c > > +++ b/drivers/acpi/nfit/core.c > > @@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus) > > > > static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n) > > { > > - struct device *dev = container_of(kobj, struct device, kobj); > > + struct device *dev = kobj_to_dev(kobj); > > struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev); > > > > if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus)) > > @@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = { > > static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj, > > struct attribute *a, int n) > > { > > - struct device *dev = container_of(kobj, struct device, kobj); > > + struct device *dev = kobj_to_dev(kobj); > > struct nvdimm *nvdimm = to_nvdimm(dev); > > struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > > > > -- > > 2.7.4 > > _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org