From: Linda Knippers <linda.knippers@hpe.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Subject: Re: [ndctl PATCH 7/8] ndctl, create-namespace: fix sector mode default for pmem namespaces
Date: Fri, 22 Apr 2016 19:07:48 -0400 [thread overview]
Message-ID: <571AAEC4.8090503@hpe.com> (raw)
In-Reply-To: <146135445871.4228.1090587699596226202.stgit@dwillia2-desk3.amr.corp.intel.com>
On 4/22/2016 3:47 PM, Dan Williams wrote:
> The man page uses the following example for establishing a sector mode
> namespace:
>
> ndctl create-namespace -e namespace0.0 -f -m sector
>
> ...however this only works for blk-type namespaces to inherit a default
> sector size. Default to 4K in the pmem-type namespaces.
>
> Reported-by: Linda Knippers <linda.knippers@hpe.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Thanks Dan.
Tested-by: Linda Knippers <linda.knippers@hpe.com>
> ---
> builtin-xaction-namespace.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/builtin-xaction-namespace.c b/builtin-xaction-namespace.c
> index 7d555a7d14a1..6ae8d7aee849 100644
> --- a/builtin-xaction-namespace.c
> +++ b/builtin-xaction-namespace.c
> @@ -410,6 +410,8 @@ static int validate_namespace_options(struct ndctl_namespace *ndns,
> else if (ndctl_namespace_get_type(ndns)
> == ND_DEVICE_NAMESPACE_BLK)
> p->sector_size = ndctl_namespace_get_sector_size(ndns);
> + else if (p->mode == NDCTL_NS_MODE_SAFE)
> + p->sector_size = 4096;
> }
>
> if (param.map) {
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2016-04-22 23:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 19:47 [ndctl PATCH 0/8] create-namespace fixes, and a misc build fix Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 1/8] ndctl, create-namespace: make zero_info_block() more robust Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 2/8] ndctl: new 'destroy-namespace' utility Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 3/8] ndctl: fix build on systems where /bin/sh is not a link to bash Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 4/8] ndctl, create-namespace: report failures due to namespace being mounted Dan Williams
2016-04-22 23:00 ` Linda Knippers
2016-04-22 23:10 ` Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 5/8] ndctl, xaction-namespace: make 'verbose' option available in all sub-commands Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 6/8] ndctl, create-namespace: fix memmap location reconfiguration Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 7/8] ndctl, create-namespace: fix sector mode default for pmem namespaces Dan Williams
2016-04-22 23:07 ` Linda Knippers [this message]
2016-04-22 19:47 ` [ndctl PATCH 8/8] ndctl, create-namespace: check for ZONE_DEVICE=n kernels Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571AAEC4.8090503@hpe.com \
--to=linda.knippers@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox