From: Linda Knippers <linda.knippers@hpe.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: acpi_nfit_query_poison() broken on non-ARS systems
Date: Mon, 2 May 2016 11:05:07 -0400 [thread overview]
Message-ID: <57276CA3.2040204@hpe.com> (raw)
In-Reply-To: <CAPcyv4g6431bUPLq3RpmoukHDeR3-n93FE=p85yhrC+gskYdjw@mail.gmail.com>
On 5/1/2016 8:33 PM, Dan Williams wrote:
> Found it. This is one of those brown-paper-bag bugs that tells me I
> need to figure out a way to unit/regression test the interface between
> acpi_nfit_ctl() and acpi_evalaute_dsm(). In this case I injected a
> __wrap_acpi_evaulate_dsm(), but I can't ship it as a new test in
> nfit_test because it relies on an enabled BIOS for all the other
> cases.
Thanks. I'll give it a try.
-- ljk
>
> diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
> index d0f35e63640b..24ef312fdba3 100644
> --- a/drivers/acpi/nfit.c
> +++ b/drivers/acpi/nfit.c
> @@ -287,8 +288,11 @@ static int acpi_nfit_ctl(struct
> nvdimm_bus_descriptor *nd_desc,
> offset);
> rc = -ENXIO;
> }
> - } else
> + } else {
> rc = 0;
> + if (cmd_rc)
> + *cmd_rc = xlat_status(buf, cmd);
> + }
>
> out:
> ACPI_FREE(out_obj);
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2016-05-02 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 23:36 acpi_nfit_query_poison() broken on non-ARS systems Linda Knippers
2016-04-30 0:03 ` Vishal Verma
2016-04-30 0:04 ` Dan Williams
2016-04-30 0:15 ` Vishal Verma
2016-04-30 0:15 ` Dan Williams
2016-04-30 0:18 ` Vishal Verma
2016-05-01 17:27 ` Linda Knippers
2016-04-30 0:12 ` Dan Williams
2016-05-01 17:42 ` Linda Knippers
2016-05-01 19:44 ` Linda Knippers
2016-05-02 0:33 ` Dan Williams
2016-05-02 15:05 ` Linda Knippers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57276CA3.2040204@hpe.com \
--to=linda.knippers@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox