From: shuah <shuah@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>,
frowand.list@gmail.com, gregkh@linuxfoundation.org,
jpoimboe@redhat.com, keescook@google.com,
kieran.bingham@ideasonboard.com, mcgrof@kernel.org,
peterz@infradead.org, robh@kernel.org, sboyd@kernel.org,
tytso@mit.edu, yamada.masahiro@socionext.com
Cc: pmladek@suse.com, linux-doc@vger.kernel.org, amir73il@gmail.com,
dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com,
linux-kselftest@vger.kernel.org, shuah <shuah@kernel.org>,
linux-nvdimm@lists.01.org, khilman@baylibre.com,
knut.omang@oracle.com, wfg@linux.intel.com, joel@jms.id.au,
rientjes@google.com, jdike@addtoit.com, dan.carpenter@oracle.com,
devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org,
Tim.Bird@sony.com, linux-um@lists.infradead.org,
rostedt@goodmis.org, julia.lawall@lip6.fr,
Bjorn Helgaas <bhelgaas@google.com>,
kunit-dev@googlegroups.com, richard@nod.at,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
daniel@ffwll.ch, mpe@ellerman.id.au,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework
Date: Tue, 20 Aug 2019 11:24:45 -0600 [thread overview]
Message-ID: <5b880f49-0213-1a6e-9c9f-153e6ab91eeb@kernel.org> (raw)
In-Reply-To: <20190814055108.214253-1-brendanhiggins@google.com>
On 8/13/19 11:50 PM, Brendan Higgins wrote:
> ## TL;DR
>
> This revision addresses comments from Stephen and Bjorn Helgaas. Most
> changes are pretty minor stuff that doesn't affect the API in anyway.
> One significant change, however, is that I added support for freeing
> kunit_resource managed resources before the test case is finished via
> kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke
> KUnit on certain configurations (like the default one for x86, whoops).
>
> Based on Stephen's feedback on the previous change, I think we are
> pretty close. I am not expecting any significant changes from here on
> out.
>
Hi Brendan,
I found checkpatch errors in one or two patches. Can you fix those and
send v14.
thanks,
-- Shuah
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-08-20 17:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 5:50 [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 03/18] kunit: test: add string_stream a std::stream like string builder Brendan Higgins
2019-08-14 7:17 ` Stephen Boyd
2019-08-14 5:50 ` [PATCH v13 04/18] kunit: test: add assertion printing library Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 07/18] kunit: test: add initial tests Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 08/18] objtool: add kunit_try_catch_throw to the noreturn list Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 10/18] kunit: test: add tests for kunit test abort Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 16/18] MAINTAINERS: add entry for KUnit the unit testing framework Brendan Higgins
[not found] ` <20190814055108.214253-1-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-08-14 5:50 ` [PATCH v13 01/18] kunit: test: add KUnit test runner core Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 02/18] kunit: test: add test resource management API Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 05/18] kunit: test: add the concept of expectations Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 06/18] kbuild: enable building KUnit Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 09/18] kunit: test: add support for test abort Brendan Higgins
2019-08-14 7:16 ` Stephen Boyd
2019-08-14 5:51 ` [PATCH v13 11/18] kunit: test: add the concept of assertions Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 12/18] kunit: test: add tests for KUnit managed resources Brendan Higgins
[not found] ` <20190814055108.214253-13-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-08-14 7:18 ` Stephen Boyd
2019-08-14 5:51 ` [PATCH v13 13/18] kunit: tool: add Python wrappers for running KUnit tests Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 14/18] kunit: defconfig: add defconfigs for building " Brendan Higgins
2019-08-14 7:18 ` Stephen Boyd
2019-08-14 5:51 ` [PATCH v13 15/18] Documentation: kunit: add documentation for KUnit Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section Brendan Higgins
2019-08-14 10:03 ` [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Brendan Higgins
2019-08-14 17:23 ` Stephen Boyd
2019-08-20 17:24 ` shuah [this message]
2019-08-20 18:24 ` Brendan Higgins
2019-08-20 19:08 ` shuah
2019-08-20 21:26 ` Brendan Higgins
2019-08-20 23:23 ` Brendan Higgins
2019-08-21 0:15 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b880f49-0213-1a6e-9c9f-153e6ab91eeb@kernel.org \
--to=shuah@kernel.org \
--cc=Alexander.Levin@microsoft.com \
--cc=Tim.Bird@sony.com \
--cc=amir73il@gmail.com \
--cc=bhelgaas@google.com \
--cc=brendanhiggins@google.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=joel@jms.id.au \
--cc=jpoimboe@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=keescook@google.com \
--cc=khilman@baylibre.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=knut.omang@oracle.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-um@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=rientjes@google.com \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=tytso@mit.edu \
--cc=wfg@linux.intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox