From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5C0D321243BA5 for ; Thu, 2 May 2019 14:18:57 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id e6so1636227pgc.4 for ; Thu, 02 May 2019 14:18:57 -0700 (PDT) Subject: Re: [PATCH v2 04/17] kunit: test: add kunit_stream a std::stream like logger References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-5-brendanhiggins@google.com> <20190502110008.GC12416@kroah.com> From: Frank Rowand Message-ID: <6fcf1218-a026-fd7b-236f-ea95f6312e1d@gmail.com> Date: Thu, 2 May 2019 14:18:53 -0700 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins , Greg KH Cc: Petr Mladek , linux-doc@vger.kernel.org, Amir Goldstein , dri-devel , Sasha Levin , Michael Ellerman , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , linux-nvdimm , Kevin Hilman , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild@vger.kernel.org, "Bird, Timothy , linux-um@lists.infradead.org, Steven Rostedt" , Julia Lawall , kunit-dev@googlegroups.com, Richard Weinberger , Stephen Boyd , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org List-ID: On 5/2/19 1:25 PM, Brendan Higgins wrote: > On Thu, May 2, 2019 at 4:00 AM Greg KH wrote: >> >> On Wed, May 01, 2019 at 04:01:13PM -0700, Brendan Higgins wrote: >>> A lot of the expectation and assertion infrastructure prints out fairly >>> complicated test failure messages, so add a C++ style log library for >>> for logging test results. >> >> Ideally we would always use a standard logging format, like the >> kselftest tests all are aiming to do. That way the output can be easily >> parsed by tools to see if the tests succeed/fail easily. >> >> Any chance of having this logging framework enforcing that format as >> well? > > I agree with your comment on the later patch that we should handle > this at the wrapper script layer (KUnit tool). This discussion is a little confusing, because it is spread across two patches. I do not agree that this should be handled in the wrapper script, as noted in my reply to patch 12, so not repeating it here. -Frank _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm