From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 776E82126CFA9 for ; Wed, 15 May 2019 17:25:19 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [RESEND PATCH] nvdimm: fix some compilation warnings Date: Thu, 16 May 2019 00:25:18 +0000 Message-ID: <7ba8164b60be4e41707559ed6623f9462c942735.camel@intel.com> References: <20190514150735.39625-1-cai@lca.pw> In-Reply-To: Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "cai@lca.pw" Cc: "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" List-ID: On Wed, 2019-05-15 at 16:25 -0700, Dan Williams wrote: > > > diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c > > index 4671776f5623..9f02a99cfac0 100644 > > --- a/drivers/nvdimm/btt.c > > +++ b/drivers/nvdimm/btt.c > > @@ -1269,11 +1269,9 @@ static int btt_read_pg(struct btt *btt, struct bio_integrity_payload *bip, > > > > ret = btt_data_read(arena, page, off, postmap, cur_len); > > if (ret) { > > - int rc; > > - > > /* Media error - set the e_flag */ > > - rc = btt_map_write(arena, premap, postmap, 0, 1, > > - NVDIMM_IO_ATOMIC); > > + btt_map_write(arena, premap, postmap, 0, 1, > > + NVDIMM_IO_ATOMIC); > > goto out_rtt; > > This doesn't look correct to me, shouldn't we at least be logging that > the bad-block failed to be persistently tracked? Yes logging it sounds good to me. Qian, can you include this in your respin or shall I send a fix for it separately (since we were always ignoring the failure here regardless of this patch)? _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm