Re: [PATCH RFC V2 14/17] dax: Stray write protection for dax_direct_access()

Peter Zijlstra
2020-07-17T09:22:56Z

On Fri, Jul 17, 2020 at 12:20:53AM -0700, ira.weiny@intel.com wrote:

> --- a/drivers/dax/super.c
> +++ b/drivers/dax/super.c
> @@ -30,12 +30,14 @@ static DEFINE_SPINLOCK(dax_host_lock);
>
> int dax_read_lock(void)
> {
> + dev_access_enable();
> return srcu_read_lock(&dax_srcu);
> }
> EXPORT_SYMBOL_GPL(dax_read_lock);
>
> void dax_read_unlock(int id)
> {
> + dev_access_disable();
> srcu_read_unlock(&dax_srcu, id);
> }
> EXPORT_SYMBOL_GPL(dax_read_unlock);

This is inconsistently ordered.