Re: [PATCH RFC V2 13/17] kmap: Add stray write protection for device pages

Peter Zijlstra
2020-07-17T09:22:01Z

On Fri, Jul 17, 2020 at 12:20:52AM -0700, ira.weiny@intel.com wrote:
> @@ -31,6 +32,20 @@ static inline void invalidate_kernel_vmap_range(void *vaddr, int size)
>
> #include <asm/kmap_types.h>
>
> +static inline void enable_access(struct page *page)
> +{
> + if (!page_is_access_protected(page))
> + return;
> + dev_access_enable();
> +}
> +
> +static inline void disable_access(struct page *page)
> +{
> + if (!page_is_access_protected(page))
> + return;
> + dev_access_disable();
> +}

These are some very generic names, do we want them to be a little more
specific?