Re: [PATCH RFC V2 12/17] memremap: Add zone device access protection

Peter Zijlstra
2020-07-17T09:13:17Z

On Fri, Jul 17, 2020 at 12:20:51AM -0700, ira.weiny@intel.com wrote:
> +static pgprot_t dev_protection_enable_get(struct dev_pagemap *pgmap, pgprot_t prot)
> +{
> + if (pgmap->flags & PGMAP_PROT_ENABLED && dev_page_pkey != PKEY_INVALID) {
> + pgprotval_t val = pgprot_val(prot);
> +
> + static_branch_inc(&dev_protection_static_key);
> + prot = __pgprot(val | _PAGE_PKEY(dev_page_pkey));
> + }
> + return prot;
> +}

Every other pgprot modifying function is called pgprot_*(), although I
suppose we have the exceptions phys_mem_access_prot() and dma_pgprot().

How about we call this one devm_pgprot() ?