From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Aneesh Kumar K.V" Subject: Re: [PATCH] mm/nvdimm: Add is_ioremap_addr and use that to check ioremap address In-Reply-To: <20190701165152.7a55299eb670b0ca326f24dd@linux-foundation.org> References: <20190701134038.14165-1-aneesh.kumar@linux.ibm.com> <20190701165152.7a55299eb670b0ca326f24dd@linux-foundation.org> Date: Tue, 02 Jul 2019 09:03:54 +0530 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <87r2792jq5.fsf@linux.ibm.com> Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: dan.j.williams@intel.com, linux-nvdimm@lists.01.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org List-ID: Andrew Morton writes: > On Mon, 1 Jul 2019 19:10:38 +0530 "Aneesh Kumar K.V" wrote: > >> Architectures like powerpc use different address range to map ioremap >> and vmalloc range. The memunmap() check used by the nvdimm layer was >> wrongly using is_vmalloc_addr() to check for ioremap range which fails for >> ppc64. This result in ppc64 not freeing the ioremap mapping. The side effect >> of this is an unbind failure during module unload with papr_scm nvdimm driver > > The patch applies to 5.1. Does it need a Fixes: and a Cc:stable? Actually, we want it to be backported to an older kernel possibly one that added papr-scm driver, b5beae5e224f ("powerpc/pseries: Add driver for PAPR SCM regions"). But that doesn't apply easily. It does apply without conflicts to 5.0 -aneesh