From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"oohall@gmail.com" <oohall@gmail.com>
Subject: Re: [PATCH v5 1/7] libndctl: Use the supported_alignment attribute
Date: Wed, 30 Jan 2019 23:20:30 +0000 [thread overview]
Message-ID: <8cd1f3f0731d2fbc98c16cbee20f8f7fa143db62.camel@intel.com> (raw)
In-Reply-To: <20190130105927.31901-1-oohall@gmail.com>
On Wed, 2019-01-30 at 21:59 +1100, Oliver O'Halloran wrote:
> Newer kernels provide the "supported_alignments" sysfs attribute that
> indicates what alignments can be used with a PFN or DAX namespace. This
> patch adds the plumbing inside of libndctl to allow users to query this
> information through using:
> ndctl_{dax|pfn}_get_supported_alignment(), and
> ndctl_{dax|pfn}_get_num_alignments()
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
> v5: Fixed comment wording
>
> v4: Changed return code of ndctl_pfn_get_supported_alignment from -1 to
> -1 to -EINVAL.
>
> Reworded comment about why we default to 4K and 2M alignments when
> the sysfs attribute is missing.
>
> Shuffled around prototypes in ndctl.h.
>
> 80 char compliance fixes.
>
> rebased onto pending branch
>
> v3: Changed the return type of the *_get_supported_alignment() functions
> to unsigned long to match the existing *_get_alignment() functions.
> ---
> ndctl/lib/libndctl.c | 43 ++++++++++++++++++++++++++++++++++++++++++
> ndctl/lib/libndctl.sym | 4 ++++
> ndctl/libndctl.h | 4 ++++
> 3 files changed, 51 insertions(+)
>
Thanks for the reworks, Oliver. I've applied the series.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-01-30 23:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 10:59 [PATCH v5 1/7] libndctl: Use the supported_alignment attribute Oliver O'Halloran
2019-01-30 10:59 ` [PATCH v5 2/7] ndctl/namespace: Check for seed namespaces earlier Oliver O'Halloran
2019-01-30 10:59 ` [PATCH v5 3/7] ndctl/namespace: Use seed alignment as the default Oliver O'Halloran
2019-01-30 10:59 ` [PATCH v5 4/7] ndctl/namespace: Validate alignment from the {pfn|dax} seed Oliver O'Halloran
2019-01-30 10:59 ` [PATCH v5 5/7] ndctl: Add alignment to the namespace JSON output Oliver O'Halloran
2019-01-30 10:59 ` [PATCH v5 6/7] ndctl/namespace: Make the create-region JSON output non-verbose Oliver O'Halloran
2019-01-30 10:59 ` [PATCH v5 7/7] ndctl: Add supported_alignments to the JSON output Oliver O'Halloran
2019-01-30 23:20 ` Verma, Vishal L [this message]
2019-03-06 6:32 ` [PATCH v5 1/7] libndctl: Use the supported_alignment attribute Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cd1f3f0731d2fbc98c16cbee20f8f7fa143db62.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox