Re: [PATCH v1 04/11] mm/memremap: add ZONE_DEVICE support for compound pages

Joao Martins
2021-05-06T10:13:17Z

On 5/6/21 12:03 AM, Dan Williams wrote:
> On Wed, May 5, 2021 at 3:36 PM Joao Martins <joao.m.martins@oracle.com> wrote:
> [..]
>>> Ah yup, my eyes glazed over that. I think this is another place that
>>> benefits from a more specific name than "align". "pfns_per_compound"
>>> "compound_pfns"?
>>>
>> We are still describing a page, just not a base page. So perhaps @pfns_per_hpage ?
>>
>> I am fine with @pfns_per_compound or @compound_pfns as well.
>
> My only concern about hpage is that hpage implies PMD, where compound
> is generic across PMD and PUD.
>
True.

I will stick with your suggestions.