From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Higgins Subject: Re: [RFC v3 03/19] kunit: test: add string_stream a std::stream like string builder Date: Fri, 30 Nov 2018 18:14:17 -0800 Message-ID: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-4-brendanhiggins@google.com> <20181130032924.GH18410@garbanzo.do-not-panic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20181130032924.GH18410@garbanzo.do-not-panic.com> Sender: linux-kernel-owner@vger.kernel.org To: mcgrof@kernel.org Cc: pmladek@suse.com, Greg KH , Kees Cook , shuah@kernel.org, Joel Stanley , mpe@ellerman.id.au, joe@perches.com, brakmo@fb.com, rostedt@goodmis.org, Tim.Bird@sony.com, khilman@baylibre.com, Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Linux Kernel Mailing List , jdike@addtoit.com, richard@nod.at, linux-um@lists.infradead.org, Daniel Vetter , dri-devel@lists.freedesktop.org, Rob Herring , dan.j.williams@intel.com, linux-nvdimm@lists.01.org, kieran.bingham@ideasonboard.com, Frank Rowand , Knut Omang List-Id: linux-nvdimm@lists.01.org On Thu, Nov 29, 2018 at 7:29 PM Luis Chamberlain wrote: > > On Wed, Nov 28, 2018 at 11:36:20AM -0800, Brendan Higgins wrote: > > A number of test features need to do pretty complicated string printing > > where it may not be possible to rely on a single preallocated string > > with parameters. > > > > So provide a library for constructing the string as you go similar to > > C++'s std::string. > > Hrm, what's the potential for such thing actually being eventually > generically useful for printk folks, I wonder? Petr? Are you saying you think this is applicable for other things? Or are you saying that you are afraid that somebody might try to use this elsewhere? In the former case, this doesn't belong here. In the latter case, it explicitly depends on KUnit, so it is only available when running tests. Cheers