From: Dan Williams <dan.j.williams@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: David Howells <dhowells@redhat.com>,
"Schofield, Alison <alison.schofield@intel.com>,
keyrings@vger.kernel.org, Kees Cook" <keescook@chromium.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v4 01/11] nfit: add support for Intel DSM 1.7 commands
Date: Fri, 13 Jul 2018 16:04:20 -0700 [thread overview]
Message-ID: <CAPcyv4hEOnyV-uJvsffW7k7r2GRm3TTQj6ew_M3L1ycxDAP-qw@mail.gmail.com> (raw)
In-Reply-To: <153142851287.27297.11888372049935247966.stgit@djiang5-desk3.ch.intel.com>
On Thu, Jul 12, 2018 at 1:48 PM, Dave Jiang <dave.jiang@intel.com> wrote:
> Add command definition for security commands defined in Intel DSM
> specification v1.7. This includes "get security state", "set passphrase",
> "unlock unit", "freeze lock", "secure erase", "ovewrite", and
> "overwrite query". Since we are adding a lot of Intel definitions, moving
> the relevant bits to its own header. Also, we don't want those commands
> to be issued from user space through ioctls. Reason being some of the
> security commands require kernel involvement to flush all CPU caches that
> can't be done in userspace and the result can cause system crash. So
> blocking security commands in the ioctl path.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/acpi/nfit/core.c | 28 ++++++++++++++++++-
> drivers/acpi/nfit/intel.h | 67 +++++++++++++++++++++++++++++++++++++++++++++
> drivers/acpi/nfit/nfit.h | 17 +++++++++++
> drivers/nvdimm/bus.c | 2 +
> include/linux/libnvdimm.h | 2 +
> 5 files changed, 112 insertions(+), 4 deletions(-)
> create mode 100644 drivers/acpi/nfit/intel.h
Looks good to me,
You can add:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-07-13 23:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 20:48 [PATCH v4 00/11] Adding security support for nvdimm Dave Jiang
2018-07-12 20:48 ` [PATCH v4 01/11] nfit: add support for Intel DSM 1.7 commands Dave Jiang
2018-07-13 23:04 ` Dan Williams [this message]
2018-07-12 20:48 ` [PATCH v4 02/11] libnvdimm: create keyring to store security keys Dave Jiang
2018-07-13 23:05 ` Dan Williams
2018-07-12 20:48 ` [PATCH v4 03/11] nfit/libnvdimm: store dimm id as a member to struct nvdimm Dave Jiang
2018-07-13 23:17 ` Dan Williams
2018-07-12 20:48 ` [PATCH v4 04/11] nfit/libnvdimm: add unlock of nvdimm support for Intel DIMMs Dave Jiang
2018-07-13 23:19 ` Dan Williams
2018-07-12 20:48 ` [PATCH v4 05/11] nfit/libnvdimm: add set passphrase support for Intel nvdimms Dave Jiang
2018-07-13 23:26 ` Dan Williams
2018-07-16 21:59 ` Dave Jiang
2018-07-16 22:12 ` Dan Williams
2018-07-12 20:49 ` [PATCH v4 06/11] nfit/libnvdimm: add disable passphrase support to Intel nvdimm Dave Jiang
2018-07-13 23:29 ` Dan Williams
2018-07-12 20:49 ` [PATCH v4 07/11] nfit/libnvdimm: add freeze security " Dave Jiang
2018-07-13 23:34 ` Dan Williams
2018-07-12 20:49 ` [PATCH v4 08/11] nfit/libnvdimm: add support for issue secure erase DSM " Dave Jiang
2018-07-13 23:42 ` Dan Williams
2018-07-12 20:49 ` [PATCH v4 09/11] nfit_test: add context to dimm_dev for nfit_test Dave Jiang
2018-07-13 23:54 ` Dan Williams
2018-07-12 20:49 ` [PATCH v4 10/11] nfit_test: add test support for Intel nvdimm security DSMs Dave Jiang
2018-07-13 23:55 ` Dan Williams
2018-07-12 20:49 ` [PATCH v4 11/11] libnvdimm: add documentation for nvdimm security support Dave Jiang
2018-07-14 0:01 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hEOnyV-uJvsffW7k7r2GRm3TTQj6ew_M3L1ycxDAP-qw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dhowells@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).