linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Keith Busch <keith.busch@intel.com>
Cc: stable <stable@vger.kernel.org>,
	linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCHv2 1/2] libnvdimm: Use max contiguous area for namespace size
Date: Thu, 5 Jul 2018 17:12:56 -0700	[thread overview]
Message-ID: <CAPcyv4iCkXkO4bcT=vvgayRqCMd9HOF++mstSFnPnK55ZLhtLA@mail.gmail.com> (raw)
In-Reply-To: <CAPcyv4hmEOJF-T9Ueqe5hcOqG11HS9RrE2ttkwqgsx2OasE5Ag@mail.gmail.com>

On Thu, Jul 5, 2018 at 2:13 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Thu, Jul 5, 2018 at 1:17 PM, Keith Busch <keith.busch@intel.com> wrote:
>> This patch will find the max contiguous area to determine the largest
>> namespace size that can be created. If the requested size exceeds the
>> largest available, ENOSPC error will be returned.
>>
>> This fixes the allocation underrun error and wrong error return code
>> that have otherwise been observed as the following kernel warning:
>>
>>   WARNING: CPU: <CPU> PID: <PID> at drivers/nvdimm/namespace_devs.c:913 size_store
>>
>> Fixes: a1f3e4d6a0c3 ("libnvdimm, region: update nd_region_available_dpa() for multi-pmem support")
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Keith Busch <keith.busch@intel.com>
>> ---
>> v1 -> v2:
>>
>>   Updated changelog to indicate the warning this patch fixes and copy
>>   stable.
>>
>>   Fixed code comments with the correct name of a function
>
> Looks good to me, applied to my for-4.18/libnvdimm tracking branch.

I take it back, this is causing the libndctl unit test to fail. debugging...
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2018-07-06  0:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 20:17 [PATCHv2 1/2] libnvdimm: Use max contiguous area for namespace size Keith Busch
2018-07-05 20:17 ` [PATCHv2 2/2] libnvdimm: Export max available extent Keith Busch
2018-07-05 21:13   ` Dan Williams
2018-07-05 21:13 ` [PATCHv2 1/2] libnvdimm: Use max contiguous area for namespace size Dan Williams
2018-07-06  0:12   ` Dan Williams [this message]
2018-07-06  1:25 ` Dan Williams
2018-07-06  1:48   ` Dan Williams
2018-07-06 22:06     ` Keith Busch
2018-07-06 22:25       ` Dan Williams
2018-07-09 15:44         ` Keith Busch
2018-07-09 21:49           ` Dan Williams
2018-07-12 15:31             ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPcyv4iCkXkO4bcT=vvgayRqCMd9HOF++mstSFnPnK55ZLhtLA@mail.gmail.com' \
    --to=dan.j.williams@intel.com \
    --cc=keith.busch@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).