From: Dan Williams <dan.j.williams@intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH] ndctl, ars: don't invalidate the user-provided command
Date: Fri, 1 Jun 2018 17:05:06 -0700 [thread overview]
Message-ID: <CAPcyv4j6KzoUuawLtMdR520ZCs0ArbAezoxUnmFki8fegJacFA@mail.gmail.com> (raw)
In-Reply-To: <20180601232814.27865-1-vishal.l.verma@intel.com>
On Fri, Jun 1, 2018 at 4:28 PM, Vishal Verma <vishal.l.verma@intel.com> wrote:
> In ndctl_cmd_ars_in_progress, which expects a successfully completed
> ars_status command, we used to invalidate the command by setting its
> status to '1', so that the user has to provide a fresh ars_status
> command the next time this check is performed.
>
> In hindsight, this is needless and violates the principle of least
> surprise. We shouldn't be touching the user's data (command), so remove
> this invalidation. If the user uses the same ars_status command again,
> we will simply report that ARS is still in progress.
>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
> ndctl/lib/ars.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
Looks good,
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-06-02 0:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 23:28 [ndctl PATCH] ndctl, ars: don't invalidate the user-provided command Vishal Verma
2018-06-02 0:05 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4j6KzoUuawLtMdR520ZCs0ArbAezoxUnmFki8fegJacFA@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).