From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x244.google.com (mail-oi0-x244.google.com [IPv6:2607:f8b0:4003:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6387721131DAA for ; Fri, 1 Jun 2018 17:05:07 -0700 (PDT) Received: by mail-oi0-x244.google.com with SMTP id f79-v6so9965460oib.7 for ; Fri, 01 Jun 2018 17:05:07 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180601232814.27865-1-vishal.l.verma@intel.com> References: <20180601232814.27865-1-vishal.l.verma@intel.com> From: Dan Williams Date: Fri, 1 Jun 2018 17:05:06 -0700 Message-ID: Subject: Re: [ndctl PATCH] ndctl, ars: don't invalidate the user-provided command List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Vishal Verma Cc: linux-nvdimm List-ID: On Fri, Jun 1, 2018 at 4:28 PM, Vishal Verma wrote: > In ndctl_cmd_ars_in_progress, which expects a successfully completed > ars_status command, we used to invalidate the command by setting its > status to '1', so that the user has to provide a fresh ars_status > command the next time this check is performed. > > In hindsight, this is needless and violates the principle of least > surprise. We shouldn't be touching the user's data (command), so remove > this invalidation. If the user uses the same ars_status command again, > we will simply report that ARS is still in progress. > > Signed-off-by: Vishal Verma > --- > ndctl/lib/ars.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) Looks good, Reviewed-by: Dan Williams _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm